telemetry for a11y updating time

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
29 days ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
I think the best thing to do is just measure how long NotificationController::WillRefresh() takes.
(Assignee)

Comment 1

5 years ago
Created attachment 644455 [details] [diff] [review]
patch
Attachment #644455 - Flags: review?(dbolter)
Comment on attachment 644455 [details] [diff] [review]
patch

Review of attachment 644455 [details] [diff] [review]:
-----------------------------------------------------------------

i like it. might want to double check with nfroyd.
r=me

Updated

5 years ago
Attachment #644455 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/bd6a571ef321
https://hg.mozilla.org/mozilla-central/rev/bd6a571ef321
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Nathan when should we expect to see this hit pentaho?
(In reply to David Bolter [:davidb] from comment #5)
> Nathan when should we expect to see this hit pentaho?

I would expect it to show up no later than tomorrow, assuming that you have people using the nightly and a11y with telemetry turned on.

...or at least I would if the code didn't have a bug.  This line:

+  Telemetry::AutoTimer<Telemetry::A11Y_UPDATE_TIME> updateTimer();

doesn't create a Telemetry::AutoTimer object called updateTimer, it declares a function called updateTimer that returns a Telemetry::AutoTimer.  You can check the disassembly and see.  So you're not actually measuring anything. :(
(Assignee)

Comment 7

5 years ago
(In reply to Nathan Froyd (:froydnj) from comment #6)
> (In reply to David Bolter [:davidb] from comment #5)
> > Nathan when should we expect to see this hit pentaho?
> 
> I would expect it to show up no later than tomorrow, assuming that you have
> people using the nightly and a11y with telemetry turned on.
> 
> ...or at least I would if the code didn't have a bug.  This line:
> 
> +  Telemetry::AutoTimer<Telemetry::A11Y_UPDATE_TIME> updateTimer();
> 
> doesn't create a Telemetry::AutoTimer object called updateTimer, it declares
> a function called updateTimer that returns a Telemetry::AutoTimer.  You can
> check the disassembly and see.  So you're not actually measuring anything. :(

yeah :( m(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

5 years ago
Created attachment 646328 [details] [diff] [review]
fix crazy c++ parsing issue
Attachment #646328 - Flags: review?(nfroyd)
Attachment #646328 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5b442d9c305
https://hg.mozilla.org/mozilla-central/rev/b5b442d9c305
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Nathan, how are we supposed to use the histogram view usefully? What is the x axis showing?
(In reply to David Bolter [:davidb] from comment #11)
> Nathan, how are we supposed to use the histogram view usefully? What is the
> x axis showing?

The x-axis shows the buckets of the histogram, with whatever units you're measuring (milliseconds, in this case).  So ~98% of the time, you're spending 0ms in the function.  Then you have a long tail of times, with slight spikes at 4 and 14ms.
(In reply to Nathan Froyd (:froydnj) from comment #12)
> (In reply to David Bolter [:davidb] from comment #11)
> > Nathan, how are we supposed to use the histogram view usefully? What is the
> > x axis showing?
> 
> The x-axis shows the buckets of the histogram, with whatever units you're
> measuring (milliseconds, in this case).  So ~98% of the time, you're
> spending 0ms in the function.  Then you have a long tail of times, with
> slight spikes at 4 and 14ms.

Oh OK!

That's not a lot of milliseconds.

Updated

29 days ago
Blocks: 1368121
You need to log in before you can comment on or make changes to this bug.