776311 - WifiWorker.js shouldn't use 'otoro' device name

Status: RESOLVED DUPLICATE of bug 801935

(Firefox OS Graveyard :: General, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

WifiWorker.js currently tries to alter it's behaviour on Otoro by checking if $(getprop ro.product.device == "otoro") [1].  However since "otoro" is just a code name and not be what the final device will be called, this code will break when running on the the /real/ otoro software stack.

[1] https://mxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#968

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Another instance of this has just occurred in the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=774876

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Hey Michael, do you have a better way of detecting when we should activate these hacks? I'd gladly switch to it! But we do need *some* way of detecting which device we're on and modifying our behavior accordingly.

Comment 3

[Michael Vines [:m1] [:evilmachines]]

IMO, we should work with the vendor to alleviate the need for them (although I understand the short-term need).

The builds that I am making do not use the otoro device name so I don't get these hacks.  The latest system image shared by the vendor over the weekend seems to have WiFi working much better BTW.  I think Kevin Hu should have them now too.

Comment 4

[Michael Wu [:mwu]]

(In reply to Blake Kaplan (:mrbkap) from comment #2)
> Hey Michael, do you have a better way of detecting when we should activate
> these hacks? I'd gladly switch to it! But we do need *some* way of detecting
> which device we're on and modifying our behavior accordingly.

We shouldn't need to unload wifi drivers in general other than to work around driver bugs. The fix for this particular case should be to stop unloading drivers on all devices.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Michael Wu [:mwu] from comment #4)
> We shouldn't need to unload wifi drivers in general other than to work
> around driver bugs. The fix for this particular case should be to stop
> unloading drivers on all devices.

We should file a new bug on this. In general, I'd prefer to follow Android's lead on this and they do unload the driver.

Comment 6

[Michael Wu [:mwu]]

Attachment: Don't unload wireless drivers

This issue has now hit the unagi.

Comment 7

[Michael Wu [:mwu]]

Actually, I just noticed another instance of "otoro" in the file so I'm going to move this patch to another bug.

Comment 8

[Andreas Gal :gal]

Nice catch. This will likely fix the issue. ++mwu