java.lang.NullPointerException: at org.mozilla.gecko.FontSizePreference.setPreviewFontViewWidth(FontSizePreference.java)

RESOLVED FIXED in Firefox 17

Status

()

Firefox for Android
General
--
critical
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: Scoobidiver (away), Assigned: mcomella)

Tracking

({crash, regression})

Trunk
Firefox 17
ARM
Android
crash, regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox16 unaffected, firefox17 fixed)

Details

(Whiteboard: [native-crash], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
There's one crash in 17.0a1/20120722: bp-885ad9fc-7e17-46d3-a24d-f365a2120722.
It might be a regression from bug 715179.

java.lang.NullPointerException
	at org.mozilla.gecko.FontSizePreference.setPreviewFontViewWidth(FontSizePreference.java:202)
	at org.mozilla.gecko.FontSizePreference.onConfigurationChanged(FontSizePreference.java:140)
	at org.mozilla.gecko.GeckoPreferences.onConfigurationChanged(GeckoPreferences.java:70)
	at android.app.ActivityThread.performConfigurationChanged(ActivityThread.java:3062)
	at android.app.ActivityThread.handleConfigurationChanged(ActivityThread.java:3186)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1012)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3835)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.FontSizePreference.setPreviewFontViewWidth%28FontSizePreference.java%29
Definitely a regression from bug 715179.
Assignee: nobody → michael.l.comella
Blocks: 715179
Keywords: regression
(Assignee)

Comment 2

5 years ago
Created attachment 645032 [details] [diff] [review]
Patch

Bug can be repo'd by changing device orientation in the Preferences menu before opening the FontSizePreference dialog.

The fix is to make sure the dialog has been opened first (by making sure its main component is initialized) before calling the associated code to modify the dialog on rotation change.
Attachment #645032 - Flags: review?(bnicholson)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
status-firefox16: --- → unaffected
status-firefox17: --- → affected
Attachment #645032 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d5e27214a62
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5d5e27214a62
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
(Reporter)

Updated

5 years ago
status-firefox17: affected → fixed
You need to log in before you can comment on or make changes to this bug.