Closed Bug 776488 Opened 10 years ago Closed 10 years ago

content/base/src/nsFrameLoader.cpp(1987) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Don't return NS_ERROR_xxxx for bool.  (bool)NS_ERROR_xxxx is true.
Attached patch fixSplinter Review
Attachment #644894 - Flags: review?(justin.lebar+bug)
Comment on attachment 644894 [details] [diff] [review]
fix

Ouch.  Thanks for catching this!
Attachment #644894 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5054c63c6e3
Assignee: nobody → m_kato
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/b5054c63c6e3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.