Last Comment Bug 776488 - content/base/src/nsFrameLoader.cpp(1987) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'
: content/base/src/nsFrameLoader.cpp(1987) : warning C4305: 'return' : truncati...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Makoto Kato [:m_kato] (PTO 6/20-21, 6/24)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-23 04:48 PDT by Makoto Kato [:m_kato] (PTO 6/20-21, 6/24)
Modified: 2012-07-24 02:57 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.10 KB, patch)
2012-07-23 04:50 PDT, Makoto Kato [:m_kato] (PTO 6/20-21, 6/24)
justin.lebar+bug: review+
Details | Diff | Review

Description Makoto Kato [:m_kato] (PTO 6/20-21, 6/24) 2012-07-23 04:48:08 PDT
Don't return NS_ERROR_xxxx for bool.  (bool)NS_ERROR_xxxx is true.
Comment 1 Makoto Kato [:m_kato] (PTO 6/20-21, 6/24) 2012-07-23 04:50:00 PDT
Created attachment 644894 [details] [diff] [review]
fix
Comment 2 Justin Lebar (not reading bugmail) 2012-07-23 07:14:05 PDT
Comment on attachment 644894 [details] [diff] [review]
fix

Ouch.  Thanks for catching this!
Comment 3 Makoto Kato [:m_kato] (PTO 6/20-21, 6/24) 2012-07-23 20:02:57 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5054c63c6e3
Comment 4 Ed Morley [:emorley] 2012-07-24 02:57:15 PDT
https://hg.mozilla.org/mozilla-central/rev/b5054c63c6e3

Note You need to log in before you can comment on or make changes to this bug.