content/base/src/nsFrameLoader.cpp(1987) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'

RESOLVED FIXED in mozilla17

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
1.10 KB, patch
Justin Lebar (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Don't return NS_ERROR_xxxx for bool.  (bool)NS_ERROR_xxxx is true.
(Assignee)

Comment 1

5 years ago
Created attachment 644894 [details] [diff] [review]
fix
Attachment #644894 - Flags: review?(justin.lebar+bug)
Comment on attachment 644894 [details] [diff] [review]
fix

Ouch.  Thanks for catching this!
Attachment #644894 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5054c63c6e3
Assignee: nobody → m_kato
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/b5054c63c6e3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.