Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove the observers added by chat-messenger-overlay.js when closing a messenger window

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 17.0

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 644914 [details] [diff] [review]
Patch

For some reason, when I initially wrote that code I assumed that now that Thunderbird has tabs, there's only one messenger window with the same life time as the application, so removing the observers wasn't needed. This is obviously wrong, so here's a patch to fix this.

Note: the patch from bug 775105 needs to be applied before this patch.
Attachment #644914 - Flags: review?(mconley)
Comment on attachment 644914 [details] [diff] [review]
Patch

I'm fine with this - thanks Florian.
Attachment #644914 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Attachment #644914 - Flags: approval-comm-beta?
Attachment #644914 - Flags: approval-comm-aurora?
Comment on attachment 644914 [details] [diff] [review]
Patch

This seems like something we want for the initial IM release.
Attachment #644914 - Flags: approval-comm-beta?
Attachment #644914 - Flags: approval-comm-beta+
Attachment #644914 - Flags: approval-comm-aurora?
Attachment #644914 - Flags: approval-comm-aurora+
comm-central: https://hg.mozilla.org/comm-central/rev/378040aa810f
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/3a5ec8e368d2
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/e3a652e552f2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.