Last Comment Bug 776518 - Move Require.jsm somewhere into toolkit to fix comm-central's busted XPCShell tests.
: Move Require.jsm somewhere into toolkit to fix comm-central's busted XPCShell...
Status: RESOLVED FIXED
[landed-in-fx-team]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Firefox 17
Assigned To: Michael Ratcliffe [:miker] [:mratcliffe]
:
:
Mentors:
Depends on:
Blocks: 776875
  Show dependency treegraph
 
Reported: 2012-07-23 06:48 PDT by Mike Conley (:mconley) - (needinfo me!)
Modified: 2012-07-25 00:42 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.46 KB, patch)
2012-07-23 08:49 PDT, Michael Ratcliffe [:miker] [:mratcliffe]
rcampbell: review-
Details | Diff | Splinter Review
Patch II - the sequel (7.85 KB, patch)
2012-07-24 04:12 PDT, Michael Ratcliffe [:miker] [:mratcliffe]
rcampbell: review+
Details | Diff | Splinter Review
require-fix (4.71 KB, patch)
2012-07-24 15:03 PDT, Rob Campbell [:rc] (:robcee)
no flags Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (needinfo me!) 2012-07-23 06:48:12 PDT
Some of toolkit's XPCShell tests now require toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn requires Require.jsm.

Unfortunately, Require.jsm is only available to browser, since it's under browser/devtools/shared.

This means that comm-central's XPCShell tests are busted (since we run toolkits XPCShell tests along with our own), and our tree is very orange.

Can we move Require.jsm and dependencies somewhere into toolkit?
Comment 1 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-23 08:49:37 PDT
Created attachment 644947 [details] [diff] [review]
Patch

Moved to Require.jsm to toolkit as requested
Comment 2 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-23 09:00:44 PDT
http://tbpl.mozilla.org/?tree=Try&rev=af8f536b5b46

This will work as long as we are not debugging dependencies. We could also move Console.jsm but that would be robcee's call.
Comment 3 Rob Campbell [:rc] (:robcee) 2012-07-23 09:14:43 PDT
(In reply to Mike Conley (:mconley) from comment #0)
> Some of toolkit's XPCShell tests now require
> toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn
> requires Require.jsm.

Why?
Comment 4 Rob Campbell [:rc] (:robcee) 2012-07-23 09:17:57 PDT
Comment on attachment 644947 [details] [diff] [review]
Patch

you should change importers of Require.jsm to resource://gre/modules/Require.jsm and update the jar file accordingly.
Comment 5 Rob Campbell [:rc] (:robcee) 2012-07-23 09:21:42 PDT
(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> (In reply to Mike Conley (:mconley) from comment #0)
> > Some of toolkit's XPCShell tests now require
> > toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn
> > requires Require.jsm.
> 
> Why?

disregard that. Dave helped me understand that we're blowing up your tests.
Comment 6 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-23 10:11:17 PDT
Can we just put the module directly under toolkit/devtools, rather than in its own directory? Flatter directory structures are better!
Comment 7 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-24 04:12:23 PDT
Created attachment 645249 [details] [diff] [review]
Patch II - the sequel

(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> Comment on attachment 644947 [details] [diff] [review]
> Patch
> 
> you should change importers of Require.jsm to
> resource://gre/modules/Require.jsm and update the jar file accordingly.

No jar involved but done.

(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #6)
> Can we just put the module directly under toolkit/devtools, rather than in
> its own directory? Flatter directory structures are better!

Done
Comment 8 Rob Campbell [:rc] (:robcee) 2012-07-24 14:14:58 PDT
Comment on attachment 645249 [details] [diff] [review]
Patch II - the sequel

I'm gonna r+ to get Tbird back up and running, but I think we should probably have gre/modules/devtools as the path. I will update and land.
Comment 9 Rob Campbell [:rc] (:robcee) 2012-07-24 14:19:44 PDT
https://hg.mozilla.org/integration/fx-team/rev/35bc0dd4080c
Comment 10 Rob Campbell [:rc] (:robcee) 2012-07-24 15:03:20 PDT
Created attachment 645522 [details] [diff] [review]
require-fix
Comment 11 Rob Campbell [:rc] (:robcee) 2012-07-24 15:35:29 PDT
Comment on attachment 645522 [details] [diff] [review]
require-fix

follow-up fix
Comment 12 Rob Campbell [:rc] (:robcee) 2012-07-24 15:37:32 PDT
https://hg.mozilla.org/integration/fx-team/rev/40bfa9aa4ab0

Note You need to log in before you can comment on or make changes to this bug.