Last Comment Bug 776528 - Chat tab title not correctly updated after closing a selected conversation
: Chat tab title not correctly updated after closing a selected conversation
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 17.0
Assigned To: Florian Quèze [:florian] [:flo] (PTO until February 27)
: instant-messaging
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-23 07:17 PDT by Florian Quèze [:florian] [:flo] (PTO until February 27)
Modified: 2012-07-23 13:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
Patch (1.53 KB, patch)
2012-07-23 07:17 PDT, Florian Quèze [:florian] [:flo] (PTO until February 27)
clokep: review+
bwinton: approval‑comm‑aurora+
bwinton: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Florian Quèze [:florian] [:flo] (PTO until February 27) 2012-07-23 07:17:12 PDT
Created attachment 644923 [details] [diff] [review]
Patch

This is because when a conversation is closed, the code attempting to update the tab title calls Services.conversations.getUIConversations() which still returns the conversation that has just been closed, and the isChat getter of that already closed conversation doesn't work because _currentTargetId has already been deleted.

An easy fix is to just send the ui-conversation-closed notification a little bit later so that the closed conversation isn't listed in the results of getUIConversations.
Comment 1 User image Blake Winton (:bwinton) (:☕️) 2012-07-23 11:55:01 PDT
Comment on attachment 644923 [details] [diff] [review]
Patch

Yeah, I really think we want to have this on aurora/beta.
Comment 3 User image Mike Conley (:mconley) 2012-07-23 13:02:27 PDT
Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as: https://hg.mozilla.org/releases/comm-beta/rev/784670aca2d2

Note You need to log in before you can comment on or make changes to this bug.