Chat tab title not correctly updated after closing a selected conversation

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 17.0

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

Attachments

(1 attachment)

Created attachment 644923 [details] [diff] [review]
Patch

This is because when a conversation is closed, the code attempting to update the tab title calls Services.conversations.getUIConversations() which still returns the conversation that has just been closed, and the isChat getter of that already closed conversation doesn't work because _currentTargetId has already been deleted.

An easy fix is to just send the ui-conversation-closed notification a little bit later so that the closed conversation isn't listed in the results of getUIConversations.
Attachment #644923 - Flags: review?(clokep)
Attachment #644923 - Flags: review?(clokep) → review+
Attachment #644923 - Flags: approval-comm-beta?
Attachment #644923 - Flags: approval-comm-aurora?
Comment on attachment 644923 [details] [diff] [review]
Patch

Yeah, I really think we want to have this on aurora/beta.
Attachment #644923 - Flags: approval-comm-beta?
Attachment #644923 - Flags: approval-comm-beta+
Attachment #644923 - Flags: approval-comm-aurora?
Attachment #644923 - Flags: approval-comm-aurora+
comm-central: https://hg.mozilla.org/comm-central/rev/6be8d163b83a
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/433c39241154
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/3cc8bae7f675
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as: https://hg.mozilla.org/releases/comm-beta/rev/784670aca2d2
You need to log in before you can comment on or make changes to this bug.