776541 - devicemanagerSUT closes the socket after each "push"

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

Robocop logs on tbpl now show a lot of "reconnecting socket" messages when a test is being set up. It appears that the SUT socket is closed by devicemanagerSUT each time a file is pushed ("push" is listed as a command that should close the socket). Closing and reopening the socket seems unnecessary, wasteful, and unexpected.

It appears this change in behavior is an unintended consequence of the patch for bug 772105.

Comment 1

[William Lachance (:wlach)]

One thing that's worth pointing out is that we weren't closing the socket before because we considered the data we were pushing a separate "command" before, which overrode the "close socket on completion" behaviour. Should be a trivial change to get the old behaviour back (just change "push" to not be a command that requires closing the socket on completion)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

yeah, this has changed now that sutagent takes the length in part of the command.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: keep socket open after 'push'

Comment 4

[William Lachance (:wlach)]

Comment on attachment 645019 [details] [diff] [review]
keep socket open after 'push'

LGTM

Comment 5

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec96af0e07f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2ec96af0e07f