devicemanagerSUT closes the socket after each "push"

RESOLVED FIXED in mozilla17

Status

Testing
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

unspecified
mozilla17
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Robocop logs on tbpl now show a lot of "reconnecting socket" messages when a test is being set up. It appears that the SUT socket is closed by devicemanagerSUT each time a file is pushed ("push" is listed as a command that should close the socket). Closing and reopening the socket seems unnecessary, wasteful, and unexpected.

It appears this change in behavior is an unintended consequence of the patch for bug 772105.
One thing that's worth pointing out is that we weren't closing the socket before because we considered the data we were pushing a separate "command" before, which overrode the "close socket on completion" behaviour. Should be a trivial change to get the old behaviour back (just change "push" to not be a command that requires closing the socket on completion)
Hardware: x86 → ARM
yeah, this has changed now that sutagent takes the length in part of the command.
(Assignee)

Updated

6 years ago
Assignee: nobody → gbrown
(Assignee)

Comment 3

6 years ago
Created attachment 645019 [details] [diff] [review]
keep socket open after 'push'
Attachment #645019 - Flags: review?(wlachance)
Comment on attachment 645019 [details] [diff] [review]
keep socket open after 'push'

LGTM
Attachment #645019 - Flags: review?(wlachance) → review+

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/2ec96af0e07f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.