change secvfy to take signature at the beginning

RESOLVED FIXED in 3.3

Status

P1
enhancement
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: jamie-bugzilla, Assigned: rrelyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
JSS hacked secvfy to take the signature when creating the context, instead of
at  the end of the operation. This requires changing the context struct to
include the signature. The code to do this already exists and works in
mozilla/security/jss/org/mozilla/jss/hclhacks/secvfy.c.
(Reporter)

Updated

18 years ago
Target Milestone: --- → 3.3
(Assignee)

Comment 1

18 years ago
OK I've made the following changes:
1) VFY_CreateContext now accepts a NULL value for the sig argument. If you
specify a NULL sig, you must specify the signature at the VFY_End time.
2) a new function was added called VFY_EndWithSignature() which takes both a
context and a signature argument. Again, you can pass NULL, but if you pass NULL
to both VFY_CreateContext and VFY_EndWithSignature() then the latter will fail
with 'INVALID PARAMETERS'. VFY_End() simply calls VFY_EndWithSignature() passing
a NULL signature.

bob
Status: NEW → ASSIGNED

Comment 2

18 years ago
Is this fixed?
Priority: -- → P1
(Assignee)

Comment 3

18 years ago
yes, I remember fixing this one specifically.

bob
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.