The default bug view has changed. See this FAQ.

Allow easily observing all calendars at once

RESOLVED FIXED in 1.9

Status

Calendar
Internal Components
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Lightning 1.5

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 645038 [details]
Fix v1 - Add interface methods and test

Right now to observe operations on all calendars at once you have to:

* Create a composite calendar, add in all current calendars
* Observe the calendar manager to reflect additions/deletions into the composite calendar
* Add an observer on the composite calendar

I'd like to simplify this a bit so all you need to do is:

* Add a (new type of) observer on the calendar manager.

This patch takes care and also adds a test. If you are wondering about the large removal of getPrefBranchFor and friends, these functions are just moved (without change) to the bottom of the file so that the actual calendar manager is at the top.
Attachment #645038 - Flags: review?(matthew.mecca)
(Assignee)

Comment 1

5 years ago
Comment on attachment 645038 [details]
Fix v1 - Add interface methods and test

Actually, there is only this part. I'm so used to missing this in extensions I create that I wasn't aware this isn't used in core (yet).
Attachment #645038 - Attachment description: Part 1 - Add interface methods and test → Fix v1 - Add interface methods and test
(Assignee)

Updated

5 years ago
Blocks: 777683
Comment on attachment 645038 [details]
Fix v1 - Add interface methods and test

Looks good. r=mmecca
Attachment #645038 - Flags: review?(matthew.mecca) → review+
(Assignee)

Comment 3

5 years ago
Pushed to comm-central changeset 71eae60afbf6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.9

Updated

5 years ago
Assignee: nobody → philipp
You need to log in before you can comment on or make changes to this bug.