Pref off new toSource method

RESOLVED FIXED in Firefox 17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dmandelin, Unassigned)

Tracking

unspecified
mozilla17
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17+ fixed)

Details

(Whiteboard: [MemShrink][qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
It's still responsible for at least a 4ms regression on SunSpider. Let's just pref it off so that we can get back to normal, and fix from there.

Comment 1

5 years ago
Created attachment 645066 [details] [diff] [review]
hacky turn off
(Reporter)

Comment 2

5 years ago
Comment on attachment 645066 [details] [diff] [review]
hacky turn off

Review of attachment 645066 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a comment next to the hacky bits and land immediately.
Attachment #645066 - Flags: review+

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d42b966e4262
Have you considered using Snappy? http://code.google.com/p/snappy/

Comment 5

5 years ago
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #4)
> Have you considered using Snappy? http://code.google.com/p/snappy/

The issue is not so much the speed of compresion rather cases when compressing completes before compilation. In the typical case, it's nice to have the better compression ratio of zlib.

Comment 6

5 years ago
(In reply to Benjamin Peterson from comment #5)
> (In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #4)
> > Have you considered using Snappy? http://code.google.com/p/snappy/
> 
> The issue is not so much the speed of compresion rather cases when
> compressing completes before compilation.

"compilation completes before compression"
This alone was a 15% regression in memory usage for the entire browser.  Hope you fix this soon!
tracking-firefox17: --- → ?
Whiteboard: [MemShrink]

Comment 8

5 years ago
Sorry! See bug 776200 for the planned fix.

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d42b966e4262
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 776741
status-firefox17: --- → fixed
tracking-firefox17: ? → +
Whiteboard: [MemShrink] → [MemShrink][qa-]
You need to log in before you can comment on or make changes to this bug.