77671 - IdFunction.java won't compile with JDK 1.1.8 javac

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Patrick C. Beard]

The javac compiler that comes with MRJ 2.2.4 won't compile IdFunction.java. For 
some reason, the assignments to the final members, master and methodId in the 
IdFunction constructor are flagged as errors.

Comment 1

[Patrick C. Beard]

Attachment: Patch to allow IdFunction.java to compile

Comment 2

[Phil Schwartau]

I've had the same problem with the JDK 1.1.8 javac on Linux!

Comment 3

[Phil Schwartau]

Here are the errors I kept getting on Linux:


javascript/../classfile/ByteCode.java
org/mozilla/javascript/../classfile/ClassFileWriter.java 
./org/mozilla/javascript/IdFunction.java:65: Blank final variable 'master' 
may not have been initialized. It must be assigned a value in an initializer, 
or in every constructor.
    public IdFunction(Master master, String name, int id) {
           ^

./org/mozilla/javascript/IdFunction.java:65: Blank final variable 'methodName' 
may not have been initialized. It must be assigned a value in an initializer, 
or in every constructor.
    public IdFunction(Master master, String name, int id) {
           ^

./org/mozilla/javascript/IdFunction.java:65: Blank final variable 'methodId' 
may not have been initialized. It must be assigned a value in an initializer, 
or in every constructor.
    public IdFunction(Master master, String name, int id) {
           ^

3 errors
make[1]: *** [classes/org/mozilla/javascript/DeepBytecodeHook.class]
Error 1
make[1]: Leaving directory `/data/phil/JS_TRUNK/mozilla/js/rhino'
make: *** [js.jar] Error 2

Comment 4

[Phil Schwartau]

The patch allows me to compile Rhino using JDK 1.1.8 on Linux.

Comment 5

[Norris Boyd]

The patch has apparently already been applied. Marking fixed.

Comment 6

[Phil Schwartau]

Marking Verified -