"Restore Default Set" on the chat toolbar selects "Icons" even though "Icons beside Text" is the visible result

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 17.0

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
STR:
- Open the chat tab (click the "Chat" button of the mail toolbar).
- Right click on the chat toolbar and select "Customize"
- Click the "Restore Default Set" button.

Expected result:
"Show: Icons beside Text"

Actual result
"Show: Icons"
(Assignee)

Comment 1

5 years ago
Created attachment 645238 [details] [diff] [review]
Patch

This patch fixes the bug, but I don't know this toolbar code at all, I just copied what's done on mail-toolbox at http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#1737 which hopefully make sense.
Assignee: nobody → florian
Attachment #645238 - Flags: review?(mconley)
Comment on attachment 645238 [details] [diff] [review]
Patch

Review of attachment 645238 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks.
Attachment #645238 - Flags: review?(mconley) → review+

Updated

5 years ago
Attachment #645238 - Flags: approval-comm-beta?
Attachment #645238 - Flags: approval-comm-aurora?
(Assignee)

Comment 3

5 years ago
[Approval Request Comment]
This is really a tiny detail, but the patch is really not risky either, so requesting approval for Tb15 anyway.
Attachment #645238 - Flags: approval-comm-beta?
Attachment #645238 - Flags: approval-comm-beta+
Attachment #645238 - Flags: approval-comm-aurora?
Attachment #645238 - Flags: approval-comm-aurora+
comm-central: https://hg.mozilla.org/comm-central/rev/26af51de257c
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/f7a52a7a0008
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/9e928d9d2ba5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.