Closed Bug 776887 Opened 12 years ago Closed 12 years ago

Edit review window does not close when Cancel button is pressed

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cboldan.mozbugs, Unassigned)

References

Details

Steps to reproduce:
1. Load details page for an app (ex. https://marketplace-dev.allizom.org/app/charm_of_/?src=mkt-search )
2. Click the "Submit a Review" link and add a review
3. Click the Edit link (not the button) and edit the review
4. Click the Edit link again to see the floating window
5. Click the Cancel button

Expected results:
The floating window is closed on the first click.

Actual results:
The floating window does not close only on the second click.

Notes/Issues:
Verified in FF17 (Win 7).
Screencast for this issue http://screencast.com/t/EfMR6j6tKu
What's actually happening is two Edit modals are opening. Pressing Cancel twice closes both dialogs.
well that probably shouldn't happen.
Assignee: nobody → ngoke
Basta already has a patch for this.
Assignee: ngoke → mattbasta
Target Milestone: --- → 2012-07-26
Fixed:

https://github.com/mozilla/zamboni/commit/a4999e24f8b7341c875d29b17b6dfa3a58af3b6a
Assignee: mattbasta → nobody
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: 2012-07-26 → ---
Verified as fixed in https://marketplace-dev.allizom.org/ on FF17 (Win 7)
Postfix screencast http://screencast.com/t/Bmt8fQR56w
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.