Closed Bug 776933 Opened 12 years ago Closed 12 years ago

test-l10n.testHtmlLocalization (timed out) - missing } after function body

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Unassigned)

Details

As for bug 776860, we were failing tests on mozilla-central on this test.

info: executing 'test-l10n.testHtmlLocalization'
error: An exception occurred.
Traceback (most recent call last):
  File "javascript:new function ContentScriptScopetScope() {
      let nodes = document.body.querySelectorAll("*[data-l10n-id]");
      self.postMessage([nodes[0].innerHTML,
                        nodes[1].innerHTML,
                        nodes[2].innerHTML,
                        nodes[3].innerHTML]);", line 6, in null
SyntaxError: missing } after function body
...
error: TEST FAILED: test-l10n.testHtmlLocalization (timed out)

It appears to be parser/stringifier issue on Javascript files being in UTF8 without BOM. The following function:
https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/tests/test-l10n.js#L94-100
is badly stringified. We are missing the closing brace `}` of the function definition.
Unfortunately I wasn't able to reproduce it with a simple test case. It seems to require a big part of the SDK (the loader? the test runner?) in order to reproduce it.
And there is no easy way to tell which mozilla-central revision introduced this issue as our tree was orange and broken on test-main while this regression has been introduced :(

The only good thing is that we can easily workaround this issue by encoding the test file in UTF8 with BOM.
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/035e6627edf03e14453552b86bac4248fca9f939
Bug 776933: test-l10n.testHtmlLocalization (timed out) - missing } after function body

https://github.com/mozilla/addon-sdk/commit/b9e57ae370c924eadbcce4f7b9aaffd1c1a56c85
Merge pull request #507 from ochameau/fix-l10n-test

Bug 776933: test-l10n.testHtmlLocalization (timed out) - missing } after function body r=me
If that's not everything, feel free to reopen it.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.