Last Comment Bug 776966 - Generate DeviceOrientationEvent implementation
: Generate DeviceOrientationEvent implementation
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: x86 All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-24 09:47 PDT by Olli Pettay [:smaug]
Modified: 2012-07-25 15:02 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (11.43 KB, patch)
2012-07-24 10:08 PDT, Olli Pettay [:smaug]
doug.turner: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2012-07-24 09:47:18 PDT
We need to add support for event ctor too, but I think that is ok.

Patch coming.
Comment 1 Olli Pettay [:smaug] 2012-07-24 10:08:57 PDT
Created attachment 645357 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=f691605847a2

Added few simple tests for the event ctor.
Comment 2 Doug Turner (:dougt) 2012-07-25 14:10:47 PDT
Comment on attachment 645357 [details] [diff] [review]
patch

lgtm
Comment 3 Olli Pettay [:smaug] 2012-07-25 14:13:18 PDT
lgtm and r- ?
Comment 4 Doug Turner (:dougt) 2012-07-25 14:13:58 PDT
Comment on attachment 645357 [details] [diff] [review]
patch

Review of attachment 645357 [details] [diff] [review]:
-----------------------------------------------------------------

bah.
Comment 5 Olli Pettay [:smaug] 2012-07-25 15:02:56 PDT
https://hg.mozilla.org/mozilla-central/rev/1901f8119667

Note You need to log in before you can comment on or make changes to this bug.