Closed Bug 776973 Opened 10 years ago Closed 10 years ago

Add a flag for apps with flash in them

Categories

(Marketplace Graveyard :: Developer Pages, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
2012-08-09

People

(Reporter: clouserw, Assigned: ashort)

References

Details

We need to add a flag for apps that use flash so we don't show them on the telefonica store.  Just stick this in the admin section for now.

Thinking ahead section:

Once we have packaged apps, this will probably become a per-file (per-version?) flag instead of per-app.  If you're forward thinking, we might be able to do that now, otherwise, we need this fixed to fix the blocker bug.  Try to do it in a way that it will be easy to transfer this to the other model, I guess.
Blocks: 776975
> Once we have packaged apps, this will probably become a per-file
> (per-version?) flag instead of per-app.  If you're forward thinking, we
> might be able to do that now, otherwise, we need this fixed to fix the
> blocker bug.  Try to do it in a way that it will be easy to transfer this to
> the other model, I guess.

This will be happening sooner rather than later.  Coordinate with robhudson on this please.
Maybe out of the scope of this bug, but we need to work out how this flag will be set once implemented (if manually, then by what testing procedure; if automagically, then by what validation routine)
This is a manual flag for now, it'll be in the admin section of the edit page.  Figuring out a testing procedure would be good, but agreed it's out of scope here.
Target Milestone: 2012-08-02 → 2012-08-09
https://github.com/mozilla/zamboni/commit/4810ea0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
I think the "[x] uses flash" option should live in the Reviewer Tools (not just the devhub admin per comment 0).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Chris Van Wiemeersch [:cvan] from comment #5)
> I think the "[x] uses flash" option should live in the Reviewer Tools (not
> just the devhub admin per comment 0).

I'm happy with it being in the devhub - its consistent for it to be there with things like the content ratings.  

Although, as we don't really know under what circumstances we're going to actually set the flag, its difficult to say.
Devhub works for v1.  As we use the flag we can find more appropriate places for it.  Thanks.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
(In reply to Wil Clouser [:clouserw] from comment #7)
> Devhub works for v1.  As we use the flag we can find more appropriate places
> for it.  Thanks.

Not all reviewers are editors though. And this is a pretty trivial change. Can we reconsider?
(In reply to Chris Van Wiemeersch [:cvan] from comment #8)
> Not all reviewers are editors though.

Not all reviewers are *admin* ;)
If reviewers are supposed to be setting the flag, sure, but this was billed as an admin flag when the feature was defined.  I don't know who is supposed to be setting it.  Once we figure out flows we can find better places to put it.
Flask checkbox does not remain checked upon Save.

See screencast: http://screencast.com/t/lPOOBDaxkhO
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://github.com/mozilla/zamboni/commit/67e581935d5f335e68329032c8da5036e446cce4
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.