776985 - Error in libs-xpcshell-tests command: shell metacharacter '~' in command line:

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Got this when building locally today:

make.py[0]: Entering directory 'c:\builds\mozilla-central\ff-debug\toolkit/mozapps/extensions/test/'
c:\builds\mozilla-central\src\config\makefiles\xpcshell.mk:30:0:native command 'nsinstall nsinstall -t  ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/data ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/head_addons.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_AddonRepository.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_AddonRepository_cache.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_AddonRepository_compatmode.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_ChromeManifestParser.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_LightweightThemeManager.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_backgroundupdate.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_badschema.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_blocklistchange.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug299716.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug299716_2.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug324121.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug335238.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug371495.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug384052.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug393285.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug394300.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug397778.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug406118.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug424262.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug425657.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug430120.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug449027.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug465190.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug468528.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug470377_1.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug470377_1_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug470377_2.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug470377_3.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug470377_3_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug470377_4.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug514327_1.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug514327_2.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug514327_3.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug521905.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug526598.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug541420.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug542391.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug554133.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug559800.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug563256.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug564030.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug566626.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug567184.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug569138.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug570173.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug576735.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug578467.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug587088.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug594058.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug595081.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug595573.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug596343.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug596607.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug616841.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug619730.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug620837.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug655254.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug659772.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug675371.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug740612.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_bug757663.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_cacheflush.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_checkcompatibility.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_compatoverrides.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_corrupt.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_corrupt_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_db_sanity.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_dictionary.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_disable.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_distribution.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_dss.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_duplicateplugins.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_error.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_filepointer.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_fuel.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_fuel.js~ ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_general.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_getresource.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Device.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_DriverNew.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_DriverNew.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_DriverOld.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_OK.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_GTE_DriverOld.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_GTE_OK.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_No_Comparison.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OK.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OS.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Vendor.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_prefs.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_hasbinarycomponents.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_hotfix.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_install.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_install_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_locale.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_locked.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_locked_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_manifest.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_migrate1.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_migrate2.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_migrate3.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_migrate4.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_migrate5.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_migrateAddonRepository.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_onPropertyChanged_appDisabled.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_permissions.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_pluginBlocklistCtp.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_plugins.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_pref_properties.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_registry.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_safemode.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_startup.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_strictcompatibility.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_syncGUID.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_targetPlatforms.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_theme.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_types.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_uninstall.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_update.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_update_compatmode.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_update_ignorecompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_update_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_updatecheck.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_updateid.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/test_upgrade_strictcompat.js ../../../../../src/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini ../../../../_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell': shell metacharacter '~' in command line

When I removed the backup file (test_fuel.js~) this completed successfully, but this seems like a common-enough operation that we shouldn't just fail.

Perhaps we can deal with this case specifically by filtering the $(wildcard $(srcdir)/$(dir)/*).

Comment 1

[Benjamin Smedberg]

Attachment: Filter out backout files, rev. 1

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 645388 [details] [diff] [review]
Filter out backout files, rev. 1

Kind of sucks, but if we're going to use $(wildcard) I guess we have to be careful.

Comment 3

[(not currently active) Ted Mielczarek]

This is a good reason to get rid of wildcards, certainly.

Comment 4

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83d701108e70

Comment 5

[Benjamin Smedberg]

This made it to -central but never got marked, oops.

Comment 6

[Benjamin Smedberg]

What actually happened is it got backed out :-(

Comment 7

[Martijn Wargers (dead)]

Attachment: updated patch

I was seeing this build error too. I had to update the patch to get it working.
Now, with this patch, I'm able to build again.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ff6a7246cb9e