Closed Bug 777068 Opened 8 years ago Closed 8 years ago

Consolidate some 3rd party Python packages to /python

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(3 files)

We now have a /python top-level directory per bug 775243!

We can seed it with some 3rd party Python packages checked into the tree. Patches forthcoming.
Move blessings from build/pylib/blessings to python/blessings.

Splinter probably won't work because I used |hg mv| and the patch has renames.
Attachment #645487 - Flags: review?(mh+mozilla)
I'm pretty sure we can move virtualenv and simplejson from other-licenses/ since I believe they have an MPL-compatible license. But, I'm not a lawyer.

Gerv: are the following licenses MPL-compatible?

https://hg.mozilla.org/mozilla-central/file/34b14c220817/other-licenses/virtualenv/LICENSE.txt
https://hg.mozilla.org/mozilla-central/file/34b14c220817/other-licenses/simplejson-2.1.1/LICENSE.txt
Comment on attachment 645487 [details] [diff] [review]
Move blessings, v1

Review of attachment 645487 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/virtualenv/packages.txt
@@ +5,5 @@
>  setup.py:testing/mozbase/mozlog:develop
>  setup.py:testing/mozbase/mozprocess:develop
>  setup.py:testing/mozbase/mozprofile:develop
>  setup.py:testing/mozbase/mozrunner:develop
> +setup.py:python/blessings:develop

You need a refresh after bug 776046
Attachment #645487 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b61beb4ae24f

Leaving open to deal with virtualenv and simplejson (possibly).
Whiteboard: [leave open]
Target Milestone: --- → mozilla17
(In reply to Gregory Szorc [:gps] from comment #2)
> Gerv: are the following licenses MPL-compatible?

Yes. Please do move these packages out of other-licenses. :-)

Gerv
Moves virtualenv to python/
Attachment #645850 - Flags: review?(mh+mozilla)
Moves simplejson to python/.

These may break without clobber because I discovered that the dependencies for virtualenv regeneration in client.mk aren't correct.
Attachment #645852 - Flags: review?(mh+mozilla)
Depends on: 777465
Attachment #645850 - Flags: review?(mh+mozilla) → review+
Attachment #645852 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/a32979765108
https://hg.mozilla.org/mozilla-central/rev/1eaa10b26d24
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.