Consolidate some 3rd party Python packages to /python

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
We now have a /python top-level directory per bug 775243!

We can seed it with some 3rd party Python packages checked into the tree. Patches forthcoming.
(Assignee)

Comment 1

5 years ago
Created attachment 645487 [details] [diff] [review]
Move blessings, v1

Move blessings from build/pylib/blessings to python/blessings.

Splinter probably won't work because I used |hg mv| and the patch has renames.
Attachment #645487 - Flags: review?(mh+mozilla)
(Assignee)

Comment 2

5 years ago
I'm pretty sure we can move virtualenv and simplejson from other-licenses/ since I believe they have an MPL-compatible license. But, I'm not a lawyer.

Gerv: are the following licenses MPL-compatible?

https://hg.mozilla.org/mozilla-central/file/34b14c220817/other-licenses/virtualenv/LICENSE.txt
https://hg.mozilla.org/mozilla-central/file/34b14c220817/other-licenses/simplejson-2.1.1/LICENSE.txt
Comment on attachment 645487 [details] [diff] [review]
Move blessings, v1

Review of attachment 645487 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/virtualenv/packages.txt
@@ +5,5 @@
>  setup.py:testing/mozbase/mozlog:develop
>  setup.py:testing/mozbase/mozprocess:develop
>  setup.py:testing/mozbase/mozprofile:develop
>  setup.py:testing/mozbase/mozrunner:develop
> +setup.py:python/blessings:develop

You need a refresh after bug 776046
Attachment #645487 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b61beb4ae24f

Leaving open to deal with virtualenv and simplejson (possibly).
Whiteboard: [leave open]
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/b61beb4ae24f
(In reply to Gregory Szorc [:gps] from comment #2)
> Gerv: are the following licenses MPL-compatible?

Yes. Please do move these packages out of other-licenses. :-)

Gerv
(Assignee)

Comment 7

5 years ago
Created attachment 645850 [details] [diff] [review]
Move virtualenv, v1

Moves virtualenv to python/
Attachment #645850 - Flags: review?(mh+mozilla)
(Assignee)

Comment 8

5 years ago
Created attachment 645852 [details] [diff] [review]
Move simplejson, v1

Moves simplejson to python/.

These may break without clobber because I discovered that the dependencies for virtualenv regeneration in client.mk aren't correct.
Attachment #645852 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Depends on: 777465
Attachment #645850 - Flags: review?(mh+mozilla) → review+
Attachment #645852 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a32979765108
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eaa10b26d24
Status: NEW → ASSIGNED
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/a32979765108
https://hg.mozilla.org/mozilla-central/rev/1eaa10b26d24
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.