The default bug view has changed. See this FAQ.

Qt fail to compile due to wrong GL includes order

RESOLVED FIXED in mozilla17

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

({regression})

Trunk
mozilla17
x86_64
Linux
regression
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Qt build got busted in inbound after some recent fix which bring GLDefs.h include into nsWindow.h:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13786738&tree=Mozilla-Inbound#error0
That broke qgl.h include because __gl_h_ got defined disabled include for GL/gl.h and GLDefs don't have standard non-local GL defines 

probably bug 776217, not sure
(Assignee)

Comment 1

5 years ago
Created attachment 645523 [details] [diff] [review]
Put QGL include before GLDefs.h

Tested on maemo and desktop qt build
Assignee: nobody → romaxa
Attachment #645523 - Flags: review?(doug.turner)

Comment 2

5 years ago
Comment on attachment 645523 [details] [diff] [review]
Put QGL include before GLDefs.h

rs+
Attachment #645523 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 3

5 years ago
Actually this change broke compilation
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd1560c17a3#l8.12
(Assignee)

Comment 4

5 years ago
Created attachment 645532 [details] [diff] [review]
GLIfdef fix, to avoid breakage in future

GLDefs version
Attachment #645532 - Flags: review?(jones.chris.g)
(Assignee)

Comment 5

5 years ago
Comment on attachment 645532 [details] [diff] [review]
GLIfdef fix, to avoid breakage in future

oh, this will not work. and break ipdl compilation
Attachment #645532 - Attachment is obsolete: true
Attachment #645532 - Flags: review?(jones.chris.g)
The breakage started with bug 771350
Blocks: 771350
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Keywords: regression
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef6fac0c8330
Status: NEW → ASSIGNED
Please remove the checkin-needed when you land your patches.
Flags: in-testsuite-
Keywords: checkin-needed
(Assignee)

Comment 9

5 years ago
oh, sorry forgot about that while was fighting with closed tree behaviour
https://hg.mozilla.org/mozilla-central/rev/ef6fac0c8330
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.