Last Comment Bug 777104 - provider menu style
: provider menu style
Status: RESOLVED FIXED
[Fx16]
:
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: unspecified
: All Mac OS X
: -- normal (vote)
: Firefox 17
Assigned To: Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-24 15:18 PDT by Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16]
Modified: 2012-07-26 13:46 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove background color (713 bytes, patch)
2012-07-24 15:19 PDT, Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16]
dao+bmo: review-
Details | Diff | Review
social menuitem style changes (730 bytes, patch)
2012-07-24 15:44 PDT, Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16]
dao+bmo: review+
Details | Diff | Review

Description Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] 2012-07-24 15:18:46 PDT
osx menus are very subtly white/transparent.  we set the background color to white in one area, which presents a very subtle difference in the background.  We should not set the background color.
Comment 1 Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] 2012-07-24 15:19:56 PDT
Created attachment 645533 [details] [diff] [review]
remove background color
Comment 2 Dão Gottwald [:dao] 2012-07-24 15:35:31 PDT
Comment on attachment 645533 [details] [diff] [review]
remove background color

Remove 'color' as well.

The winstripe styling is also bogus, by the way.
Comment 3 Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] 2012-07-24 15:44:35 PDT
Created attachment 645545 [details] [diff] [review]
social menuitem style changes

color removed, win/lin will have to be looked at by jaws, I don't have build VMs (while traveling)
Comment 4 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-26 13:46:55 PDT
https://hg.mozilla.org/mozilla-central/rev/9919f35f5514

Note You need to log in before you can comment on or make changes to this bug.