749 bytes, patch
|Details | Diff | Splinter Review|
1.) Visit a site with java like http://www.sj-downtown.com. 2.) Click Back, then on File, Quit. What happens: The browser crashes.
The _particular_ variation works, perhaps due to today's fixes for bug #76936 and bug #79872. However, bug #81631, quitting with an applet running, still exists. Man, loading http://www.mozilla.org/quality/browser/front-end/testcases/oji/test2.html takes forEVER now.
The bug is back today (with a late build from 21May) but with a different crash signature. Probably all the LiveConnect work and lazy-loading of Java stuff getting hashed out. Last few calls in the stack crawl: nsPluginHostImpl::Destroy()+34 nsActivePluginList::stopRunning()+48 MRJPluginInstance::SetWindow(nsPluginWindow*)+28 MRJContext::setWindow(nsPluginWindow*)+8c MRJContext::synchronizeClipping()+a4 .... then crash in NQDSetRectRgn
when quitting after close, nsActivePluginList::stopRunning() calls MRJPluginInstance::SetWindow() with a nil window a second time (the first was during close of window) but the attempted MRJPlugin.cpp;line #743 'mContext->setWindow(pluginWindow);' is doomed to failure as this->mContext is nil by now.
oops, I meant that SetWindow is called a second time. nsActivePluginList::stopRunning isn't involved when the window gets closed. In any case, mContext has been set to null, and MRJPluginInstance::SetWindow() and MRJPluginInstance::Stop() (which have already been called) aren't expecting that. As a workaround, putting 'if (mContext)' checks in those two routines prevents today's 77714 crash.
Created attachment 35628 [details] [diff] [review] quickie work-around for today's incarnation of 77714
bug has disappeared in build from morning of 5.29.01
Updating Status Whiteboard to indicate a bug actively being worked on by Terry.
stack crawl has now changed (6/14 am build) to nsJVMManager::Release()+18 nsJVMManager::Internal::Release()+48
*** This bug has been marked as a duplicate of 81631 ***
Reopening. Not really a dupe, and still reproducible.
Worksforme with the 7/25 Mac RTM build.