777142 - Adjust the validator to recognize a packaged app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect, P1)

Description

[Wil Clouser [:clouserw]]

The only spec for a packaged app right now is that it has a valid manifest.webapp in its root directory.  Rob is doing the other end of this (the uploading the file to zamboni part) so work with him if there are questions.

Also bug 777140 is about signed zips, you can ignore that for now since it's not spec'd out yet.

Comment 1

[Matt Basta [:basta]]

The new validator is located here for now:

https://github.com/mattbasta/app-validator

Once added to vendor, it'll be accessible as `appvalidator` instead of `validator`. It'll expose the `validate_app()` that's in the current validator, as well as `validate_packaged_app()`.

We won't need to deal with signed apps, since that's a post-review thing. We will eventually, however, need to know about what the final version of the CSP stuff is going to look like. We'll also need to have a comprehensive list of all of the APIs that are going to be exposed to packaged apps.

Comment 2

[Jason Smith [:jsmith]]

Per triage discussion, it's really critical in building this validator to make sure that useful error reports that is sent back when the packaged app does not work correctly. We are not planning to provide "useful" error codes for basecamp in the installPackage API, so nailing this down in the validator is critical.

Comment 3

[Matt Basta [:basta]]

(In reply to Jason Smith [:jsmith] from comment #2)
> Per triage discussion, it's really critical in building this validator to
> make sure that useful error reports that is sent back when the packaged app
> does not work correctly. We are not planning to provide "useful" error codes
> for basecamp in the installPackage API, so nailing this down in the
> validator is critical.

Can you define "when the packaged app does not work correctly"?

Comment 4

[Jason Smith [:jsmith]]

(In reply to Matt Basta [:basta] from comment #3)
> (In reply to Jason Smith [:jsmith] from comment #2)
> > Per triage discussion, it's really critical in building this validator to
> > make sure that useful error reports that is sent back when the packaged app
> > does not work correctly. We are not planning to provide "useful" error codes
> > for basecamp in the installPackage API, so nailing this down in the
> > validator is critical.
> 
> Can you define "when the packaged app does not work correctly"?

Sure. I'll define this generally in terms of what to check and include the details of the not working cases. Here's what I know so far (more details to come though as I build a test plan):

- A general check that in the zip file (or generally checking it's a zip file in the first place), a manifest.webapp exists in the root directory of the zip file that is a valid app manifest against the old app manifest validator
- The launch path of the app in the app manifest points to valid content that exists. Meaning, if I install the packaged app and launch it, it sends me to content that exists within the zip file and does not result in a "file not found" error.
- (if possible, may be overkill for validator) crawling the packaged apps content to ensure that there are no broken links generally in the app that points to content that does not exist

I'll get more details on this as I draft the test plan for packaged apps.
-

Comment 5

[Matt Basta [:basta]]

Are there any sample packaged apps available that can be used for testing?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Matt Basta [:basta] from comment #5)
> Are there any sample packaged apps available that can be used for testing?

Fabrice built one example here:

- Page for testing: http://people.mozilla.org/~fdesre/openwebapps/test.html
- Direct zip file: http://people.mozilla.org/~fdesre/openwebapps/fbowd.zip

I'll start working on some examples in my testing to help here as well.

Comment 7

[Matt Basta [:basta]]

Repo, updated as of ~2pm:

https://github.com/mozilla/app-validator

Comment 8

[Rob Hudson [:robhudson]]

This is hooked up to -dev as of bug 777138.

Comment 9

[Matt Basta [:basta]]

Krupa: Have your way with the app validator

Comment 10

[Matt Basta [:basta]]

Many thanks to @robhudson for all his hard work on getting this working :3

Comment 11

[Jason Smith [:jsmith]]

Not an on-device bug. Removing nom.

Comment 12

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/developers/submit/app/manifest on FF20 (Win 7)
Postfix screencast http://screencast.com/t/EEmmTmjsdV
Closing bug.