Last Comment Bug 777205 - Should remove unused wrap length value in nsMsgAttachmentHandler::UrlExit
: Should remove unused wrap length value in nsMsgAttachmentHandler::UrlExit
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Composition (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 17.0
Assigned To: Hiroyuki Ikezoe (:hiro)
:
Mentors:
Depends on:
Blocks: 155219
  Show dependency treegraph
 
Reported: 2012-07-24 18:36 PDT by Hiroyuki Ikezoe (:hiro)
Modified: 2012-08-04 07:16 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix (1.48 KB, patch)
2012-07-24 18:36 PDT, Hiroyuki Ikezoe (:hiro)
standard8: review+
Details | Diff | Splinter Review

Description Hiroyuki Ikezoe (:hiro) 2012-07-24 18:36:43 PDT
Created attachment 645618 [details] [diff] [review]
Fix
Comment 1 :aceman 2012-07-25 08:02:45 PDT
Good catch. The width is determined but the variable never used. The real text conversion is done in ConvertBufToPlainText() and that one fetches the pref itself (and caps the width differently).

This will help bug 155219 to reduce confusion about the various manglings of the pref value.
Comment 2 Hiroyuki Ikezoe (:hiro) 2012-07-25 15:38:09 PDT
aceman, thank you for the info. There are lots of wrap length issues. We need WADA there too. ;-p
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-08-04 07:16:52 PDT
https://hg.mozilla.org/comm-central/rev/2368e7da5f4b

Note You need to log in before you can comment on or make changes to this bug.