The content of History and Top Sites sections is not cleared when clearing private data

VERIFIED FIXED

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
10 months ago

People

(Reporter: Paul Feher, Assigned: bnicholson)

Tracking

15 Branch
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Firefox Mobile Native 15.0b2 build1 (2012-07-24)
Device: HTC Desire Z(Android 2.3.3)/HTC Desire (Android 2.2)

Steps to reproduce:
1. Load a few pages.
2. Clear private data. Make sure "Browsing&Download History" is selected.
4. Open the Awesome-bar and check the History and Top Sites sections.

Expected results:
The History and Top Sites sections are empty.

Actual results:
The records from History and Top Sites sections are still present.
(Reporter)

Updated

5 years ago
tracking-fennec: --- → ?
status-firefox15: --- → affected
(Assignee)

Comment 1

5 years ago
(In reply to Paul Feher from comment #0)
> Firefox Mobile Native 15.0b2 build1 (2012-07-24)
> Device: HTC Desire Z(Android 2.3.3)/HTC Desire (Android 2.2)
> 
> Steps to reproduce:
> 1. Load a few pages.
> 2. Clear private data. Make sure "Browsing&Download History" is selected.
> 4. Open the Awesome-bar and check the History and Top Sites sections.
> 
> Expected results:
> The History and Top Sites sections are empty.
> 
> Actual results:
> The records from History and Top Sites sections are still present.

Do you have Sync set up? Right now, I think clearing private data only clears local data.
(Reporter)

Comment 2

5 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #1)
> (In reply to Paul Feher from comment #0)
> > Firefox Mobile Native 15.0b2 build1 (2012-07-24)
> > Device: HTC Desire Z(Android 2.3.3)/HTC Desire (Android 2.2)
> > 
> > Steps to reproduce:
> > 1. Load a few pages.
> > 2. Clear private data. Make sure "Browsing&Download History" is selected.
> > 4. Open the Awesome-bar and check the History and Top Sites sections.
> > 
> > Expected results:
> > The History and Top Sites sections are empty.
> > 
> > Actual results:
> > The records from History and Top Sites sections are still present.
> 
> Do you have Sync set up? Right now, I think clearing private data only
> clears local data.

This happens with a clean profile without any sync account being set up. The local data is not cleared.
(Assignee)

Updated

5 years ago
Duplicate of this bug: 778394
(Assignee)

Comment 4

5 years ago
Created attachment 647081 [details] [diff] [review]
Fix check to clear Java-side history

Bug 775042 changed the "history" key to "history_downloads". PrivateDataPreference.java wasn't updated for this change, breaking this feature. We didn't need this patch in 16+ because bug 771036 changed the "Sanitize:ClearHistory" message to be fired from JS instead.

So for beta, our options are to either land this or bug 771036. Bug 771036 seems like a low risk patch; it might be nice to land that so add-ons can also be fixed.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #647081 - Flags: review?(mark.finkle)
Attachment #647081 - Flags: review?(mark.finkle) → review+
This patch is drop dead simple, so let's use it for Fx15. Please nom for uplift.
(Assignee)

Comment 6

5 years ago
Comment on attachment 647081 [details] [diff] [review]
Fix check to clear Java-side history

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 775042
User impact if declined: history cannot be cleared
Testing completed (on m-c, etc.): tried locally and it works
Risk to taking this patch (and alternatives if risky): low risk, beta only
String or UUID changes made by this patch: none
Attachment #647081 - Flags: approval-mozilla-beta?

Updated

5 years ago
Attachment #647081 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/mozilla-beta/rev/5d967bdec4a3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox15: affected → fixed
Resolution: --- → FIXED

Updated

5 years ago
Duplicate of this bug: 779186

Updated

5 years ago
Duplicate of this bug: 779226

Comment 10

5 years ago
Verified on Nexus 7 , JB4.1.1, Fennec 15 beta 3.
Status: RESOLVED → VERIFIED

Comment 11

5 years ago
Also works again on SGS2 with Android 4.0.3.

Updated

5 years ago
status-firefox15: fixed → verified
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.