Created attachment 645707 [details] [diff] [review]
Warning: ReferenceError: reference to undefined property tab.thinking
Source File: chrome://messenger/content/tabmail.xml
I've wasted enough time looking at this warning and wondering if it was caused by my chat tab missing a JS property, or my changes breaking something in the gloda facet view tab that I think it's worth fixing. Hopefully it will save time for others too :).
Steps to reproduce:
- Open Thunderbird, the 3 pane view is selected by default.
- Open a second tab.
- Select the 3 pane tab.
The warning appears when selecting the 3 pane tab for the first time (not when it was automatically selected at startup).
The cause is simply that the thinking property is never initialized for the first tab: http://hg.mozilla.org/comm-central/annotate/3f7c3f228397/mail/base/content/tabmail.xml#l413
Here's the initialization for the other tabs: http://hg.mozilla.org/comm-central/annotate/3f7c3f228397/mail/base/content/tabmail.xml#l470
Trivial patch attached.
Comment on attachment 645707 [details] [diff] [review]
I like it. Thanks Florian.