Closed Bug 777303 Opened 8 years ago Closed 7 years ago

JavaScript strict warning: chrome://messenger/content/tabmail.xml, line 1106: reference to undefined property tab.thinking

Categories

(Thunderbird :: Toolbars and Tabs, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: florian, Unassigned)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Warning: ReferenceError: reference to undefined property tab.thinking
Source File: chrome://messenger/content/tabmail.xml
Line: 1106

I've wasted enough time looking at this warning and wondering if it was caused by my chat tab missing a JS property, or my changes breaking something in the gloda facet view tab that I think it's worth fixing. Hopefully it will save time for others too :).

Steps to reproduce:
- Open Thunderbird, the 3 pane view is selected by default.
- Open a second tab.
- Select the 3 pane tab.

The warning appears when selecting the 3 pane tab for the first time (not when it was automatically selected at startup).


The cause is simply that the thinking property is never initialized for the first tab: http://hg.mozilla.org/comm-central/annotate/3f7c3f228397/mail/base/content/tabmail.xml#l413
Here's the initialization for the other tabs: http://hg.mozilla.org/comm-central/annotate/3f7c3f228397/mail/base/content/tabmail.xml#l470

Trivial patch attached.
Attachment #645707 - Flags: review?(mconley)
Comment on attachment 645707 [details] [diff] [review]
Patch

I like it. Thanks Florian.
Attachment #645707 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/d691b48ea0f6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.