Last Comment Bug 777355 - Move Console.jsm somewhere into toolkit to fix comm-central's busted XPCShell tests.
: Move Console.jsm somewhere into toolkit to fix comm-central's busted XPCShell...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 17
Assigned To: Michael Ratcliffe [:miker] [:mratcliffe]
:
Mentors:
Depends on:
Blocks: 777993
  Show dependency treegraph
 
Reported: 2012-07-25 07:56 PDT by Michael Ratcliffe [:miker] [:mratcliffe]
Modified: 2012-07-27 09:58 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (12.78 KB, patch)
2012-07-25 10:38 PDT, Michael Ratcliffe [:miker] [:mratcliffe]
rcampbell: review+
Details | Diff | Splinter Review

Description Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-25 07:56:33 PDT
We have moved Require.jsm into toolkit but failed to move Console.jsm with it.

Some of toolkit's XPCShell tests now require toolkit/devtools/sourcemap/tests/unit/Utils.jsm, and Utils.jsm in turn requires Require.jsm which in turn requires Console.jsm

Unfortunately, Console.jsm is only available to browser, since it's under browser/devtools/shared.

This means that comm-central's XPCShell tests are busted (since they run toolkit's XPCShell tests along with their own), and their tree is a shocking shade of orange.

Console.jsm needs to be moved into toolkit?
Comment 1 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-25 10:38:26 PDT
Created attachment 645809 [details] [diff] [review]
Patch

Moved Console.jsm to toolkit.

Also changed Console.jsm and Require.jsm paths to resource://gre/modules/devtools/*.jsm as requested by robcee in https://bugzilla.mozilla.org/show_bug.cgi?id=776518#c8
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-25 11:07:30 PDT
Comment on attachment 645809 [details] [diff] [review]
Patch

>diff --git a/toolkit/devtools/Makefile.in b/toolkit/devtools/Makefile.in

>-EXTRA_JS_MODULES = \
>-  Require.jsm \
>-  $(NULL)
>+include $(topsrcdir)/config/rules.mk
> 
>-include $(topsrcdir)/config/rules.mk
>+libs::
>+	$(NSINSTALL) $(srcdir)/*.jsm $(FINAL_TARGET)/modules/devtools

This stuff should really be using bug 773933's JS_MODULES_PATH. I guess you probably don't want to block on that, so we can clean this up after the fact.
Comment 3 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-25 12:39:41 PDT
Comment on attachment 645809 [details] [diff] [review]
Patch

I didn't realize that it hadn't landed yet. Asking robcee for review again.
Comment 4 Mike Conley (:mconley) - (Needinfo me!) 2012-07-26 07:06:26 PDT
If it helps speed up the review process, I can tell you that with this patch, the failing tests go green again.
Comment 5 Rob Campbell [:rc] (:robcee) 2012-07-26 07:43:09 PDT
Comment on attachment 645809 [details] [diff] [review]
Patch

I hope joe doesn't hate me for this...
Comment 6 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-26 08:44:48 PDT
Please could we create a followup bug that makes us tidy up the implementation a bit.
Before this move it was kind of private
Comment 7 Rob Campbell [:rc] (:robcee) 2012-07-26 16:41:53 PDT
(In reply to Joe Walker from comment #6)
> Please could we create a followup bug that makes us tidy up the
> implementation a bit.
> Before this move it was kind of private

yes, yes we can.
Comment 8 Rob Campbell [:rc] (:robcee) 2012-07-26 16:48:18 PDT
https://hg.mozilla.org/integration/fx-team/rev/efba40dd1a70
Comment 9 Michael Ratcliffe [:miker] [:mratcliffe] 2012-07-26 17:01:27 PDT
(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> (In reply to Joe Walker from comment #6)
> > Please could we create a followup bug that makes us tidy up the
> > implementation a bit.
> > Before this move it was kind of private
> 
> yes, yes we can.

Bug 777993 logged.
Comment 10 Tim Taubert [:ttaubert] 2012-07-27 09:58:29 PDT
https://hg.mozilla.org/mozilla-central/rev/efba40dd1a70

Note You need to log in before you can comment on or make changes to this bug.