Status

Testing
Talos
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
* if a platform has no results, print no results
* if there are no results for a test, print that, no 99999

* ensure that all fields are optional with adequate help to find valid fields.
(Assignee)

Comment 1

6 years ago
* add :) or :( if the range is better or worse
* add minified links to graph server.
(Assignee)

Comment 2

6 years ago
these should be fixed in:
http://people.mozilla.org/~jmaher/sxs/compare.py

If all is working well, I will put a patch up to add this to the talos repository.
(Assignee)

Comment 3

6 years ago
Created attachment 647884 [details] [diff] [review]
add compare.py to the talos repository (1.0)

this version of compare.py addresses all the wish list items in this bug also.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #647884 - Flags: review?(jhammel)

Comment 4

6 years ago
As long as the bug title has wish list in it, mine is to have this replace compare-talos

http://perf.snarkfest.net/compare-talos/

Comment 5

6 years ago
Comment on attachment 647884 [details] [diff] [review]
add compare.py to the talos repository (1.0)

Thanks, Joel, this looks really good, and I think having it in talos would be good.  There are numerous TODOs, but you have noted some of them nor are they high priority.  I'd really love to combine this with other efforts towards the same direction, particularly http://perf.snarkfest.net/compare-talos/ and datazilla, but AIUI this is mostly a stop gap until we have the new death star, er, i mean datazilla up and running.

I would probably make a top-level subdirectory, scripts/, for this, but maybe overkill for just one

Nits:

+    low = 999999

I don't really like this pattern.  I'd use sys.maxint if i *really* didn't want to check for None, though I'd probably just check for None

in main():
+    global platforms, tests

You would only need these here if you wrote to these variables.  You don't

+            print "ERROR: please specify the skipdays between 0-30"
+            sys.exit(1)

i would probably use parser.error("ERROR: please...") for these lines

+    headers['user-agent'] = "python-googl"

Is that correct?  FWIW, I absolutely hate short urls.
Attachment #647884 - Flags: review?(jhammel) → review+
(Assignee)

Comment 6

6 years ago
landed in talos with as many nits as possible to address:
http://hg.mozilla.org/build/talos/rev/3eff7fc999ca

NOTE: I needed the global variables since I was assigning platforms and tests.  Also setting to None didn't work with my comparison to a number.  It would have made the code a bit uglier.

Lets work on filing more bugs to make this a good tool for the next 4-6 months while we transition to datazilla.
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
Sounds like a plan
You need to log in before you can comment on or make changes to this bug.