777401 - DictionaryHelpers.* build problems

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

bz saw a case when .cpp was re-created but .h wasn't.
I think this is actually because of https://hg.mozilla.org/mozilla-central/rev/252f295c4664
https://bugzilla.mozilla.org/show_bug.cgi?id=765163#c27

I'm testing the approach where .cpp and .h are always generated at the same time.

Ofc, I really don't have much experience with this kind of dependency handling in
Makefiles, so Kyle, all the comments welcome :)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

So, the patch is a bit ugly, but I'm trying to reuse the same dependencies for the .h as what
.cpp has.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

...and the patch does actually fix the problem I see. If some idl file is changed, we don't
regenerate the .h.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 645804 [details] [diff] [review]
patch

Kyle, could you accept this kind of hack, or is this too ugly, in which case should I add dependency checking specific to .h file?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 645804 [details] [diff] [review]
patch

Review of attachment 645804 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change we discussed on irc.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/23a7ba542bb5