Closed Bug 777401 Opened 10 years ago Closed 10 years ago

DictionaryHelpers.* build problems

Categories

(Core :: XPConnect, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files)

Attached patch patchSplinter Review
bz saw a case when .cpp was re-created but .h wasn't.
I think this is actually because of https://hg.mozilla.org/mozilla-central/rev/252f295c4664
https://bugzilla.mozilla.org/show_bug.cgi?id=765163#c27

I'm testing the approach where .cpp and .h are always generated at the same time.

Ofc, I really don't have much experience with this kind of dependency handling in
Makefiles, so Kyle, all the comments welcome :)
So, the patch is a bit ugly, but I'm trying to reuse the same dependencies for the .h as what
.cpp has.
...and the patch does actually fix the problem I see. If some idl file is changed, we don't
regenerate the .h.
Comment on attachment 645804 [details] [diff] [review]
patch

Kyle, could you accept this kind of hack, or is this too ugly, in which case should I add dependency checking specific to .h file?
Attachment #645804 - Flags: review?(khuey)
Comment on attachment 645804 [details] [diff] [review]
patch

Review of attachment 645804 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change we discussed on irc.
Attachment #645804 - Flags: review?(khuey) → review+
Attached patch patchSplinter Review
https://hg.mozilla.org/mozilla-central/rev/23a7ba542bb5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.