777525 - Implement partners page redesign

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Mike Alexis [:malexis]]

Designs coming soon.

Comment 1

[Mike Alexis [:malexis]]

ETA for designs is 8/16

Comment 2

[Gregory Jost]

Quick note for implementation:
"Title" refers to prospects' roles, not civility, so let's keep the field order and content of the current page vs Ty's new design.

Can we also update the product interest header and the list:
Product Interest --> Interest
Firefox Desktop (Mac/Linux/PC) --> Firefox for Desktop
Firefox Mobile --> Firefox for Android
Firefox Apps Marketplace --> Firefox Marketplace
Firefox Boot2Gecko --> Firefox OS
Promotion/Marketing Program --> Marketing and Co-promotions
Other --> Other

Comment 3

[Mike Alexis [:malexis]]

PSD can be grabbed from here:

https://www.dropbox.com/s/31g1s3yv4hm9pq8/Moz_About_Partnerships_Final.psd.zip

Comment 4

[Steven Garrity [:sgarrity]]

Implementation is done, pull request pending review on GitHub: https://github.com/mozilla/bedrock/pull/327

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/da79a84900965992a70b2cf183a4cde4ec4f074e
Bug 777525 - Implement partners page redesign

Comment 6

[Anthony Ricaud (:rik)]

Gregory: Can you review http://www.allizom.org/en-US/about/partnerships/ ?

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a9d5f1f9ec4f3fbd9d429c7046c4fd76285e90c8
Revert "Bug 777525 - Implement partners page redesign"

This reverts commit da79a84900965992a70b2cf183a4cde4ec4f074e.

Comment 8

[Anthony Ricaud (:rik)]

Please ignore comment 6.

The URL to review this is http://www-dev.allizom.org/en-US/about/partnerships/

Comment 9

[raymond [:retornam] (inactive)]

qa-verified-trunk http://www-dev.allizom.org/en-US/about/partnerships/

Comment 10

[Gregory Jost]

I am looking at http://www-dev.allizom.org/en-US/about/partnerships/ and I don't see the new design or any of the changes mentioned on comment 2.

Am I using the correct link?

Thanks.
G

Comment 11

[Steven Garrity [:sgarrity]]

(In reply to Gregory Jost from comment #10)
> I am looking at http://www-dev.allizom.org/en-US/about/partnerships/ and I
> don't see the new design or any of the changes mentioned on comment 2.

This appears to have been reverted by Anthony in Comment #7:

https://github.com/mozilla/bedrock/commit/a9d5f1f9ec4f3fbd9d429c7046c4fd76285e90c8

Not sure why. CC'ing Anthony.

Comment 12

[Anthony Ricaud (:rik)]

IIRC, I reverted because we didn't want to launch without someone taking a look at it and Greg was on holidays. But I may have forgotten to put it on dev (or maybe it was overwritten by something else later). Sorry about that.

Anyway, I reverted the revert in https://github.com/mozilla/bedrock/commit/d1d56a1dfd887339dad9fabc6f6e964d852e4e9a

http://www-dev.allizom.org/en-US/about/partnerships/ is ready to be looked at.

Comment 13

[Gregory Jost]

Thanks!

Here's my feedback:
- Can we capitalize the "D" for "Firefox for Desktop"?
- On the form: the "address" and "description" labels are not formatted correctly

That's all I have for now!

Comment 14

[Steven Garrity [:sgarrity]]

(In reply to Gregory Jost from comment #13)
> Here's my feedback:
> - Can we capitalize the "D" for "Firefox for Desktop"?
> - On the form: the "address" and "description" labels are not formatted
> correctly

These changes have been made and there's a new pull request: https://github.com/mozilla/bedrock/pull/361

Comment 15

[Tara (musingt)]

I talked to Mark and he suggested we add a captcha or some similar system to the form in order to reduce the amount of spam we receive right now ("probably 98%")?

I realize this wasn't part of the initial scope. Let me know if I should file a seperate bug for that.

Thanks!

Comment 16

[Steven Garrity [:sgarrity]]

(In reply to Tara (musingt) from comment #15)
> I talked to Mark and he suggested we add a captcha or some similar system to
> the form in order to reduce the amount of spam we receive right now
> ("probably 98%")?
> 
> I realize this wasn't part of the initial scope. Let me know if I should
> file a seperate bug for that.

Yes, a separate bug would be helpful for this. Thanks.

Comment 17

[Mark Crandon]

Attachment: Lead SPAM examples

The attached document gives you an idea of the automated spam garbage that's being injected into the forms.

Comment 18

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a09b5c1b02c8ff2a6babeea2a239ca7423abe546
Bug 777525 - Implement partners page redesign

https://github.com/mozilla/bedrock/commit/f2e767d609ebddc729facf50c3ce580338236c85
Minor style/capitalization tweaks from  feedback
on Bug 777525

Comment 19

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d33d9d79263fdb8295c221e4479715477587d3f7
Bug 777525 - Implement partners page redesign

https://github.com/mozilla/bedrock/commit/45188f09b3579c26fa4f4dfa0e4a599523f4c17b
Minor style/capitalization tweaks from  feedback
on Bug 777525

Comment 20

[raymond [:retornam] (inactive)]

q-verified-trunk http://www.mozilla.org/en-US/about/partnerships/

Comment 21

[Anthony Ricaud (:rik)]

This has been pushed to production.

Comment 22

[Gregory Jost]

Thanks everyone.

Comment 23

[raymond [:retornam] (inactive)]

verified fixed http://www.mozilla.org/en-US/about/partnerships/