Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add MOCHITEST_FILES to FREEZE_VARIABLES

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
So we don't disable them by accident.
(Assignee)

Comment 1

5 years ago
Created attachment 646037 [details] [diff] [review]
Make sure we can't accidentally turn off mochitests for a directory by reordering the Makefile.in.
Attachment #646037 - Flags: review?(khuey)
Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?
Attachment #646037 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

5 years ago
> Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?

Good catch.  When I do, I get:

/Users/bzbarsky/mozilla/inbound/mozilla/config/rules.mk:1769: *** Makefile variable 'MOCHITEST_BROWSER_FILES' changed value after including rules.mk. Was '', now browser/head.js browser/crashreport.sjs browser/browser_aboutCrashes.js browser/browser_bug471404.js browser/browser_aboutCrashesResubmit.js ..  Stop.
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/137efb901fc9
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [need review]
Target Milestone: --- → mozilla17

Comment 5

5 years ago
Backed out for:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1&rev=f4796a2c5af3

https://tbpl.mozilla.org/php/getParsedLog.php?id=13877584&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13877556&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13877580&tree=Mozilla-Inbound
etc

(rest of push left in)

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2dd0b6c4cb4
Target Milestone: mozilla17 → ---

Comment 6

5 years ago
Sorry s/&onlyunstarred=1// in the previous comment's first URL.
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9085598907ef with the fix for that, which was apparently in an earlier patch in my queue.
https://hg.mozilla.org/mozilla-central/rev/9085598907ef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.