777627 - Add MOCHITEST_FILES to FREEZE_VARIABLES

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

So we don't disable them by accident.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure we can't accidentally turn off mochitests for a directory by reordering the Makefile.in.

Comment 2

[Nathan Froyd [:froydnj]]

Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?

Good catch.  When I do, I get:

/Users/bzbarsky/mozilla/inbound/mozilla/config/rules.mk:1769: *** Makefile variable 'MOCHITEST_BROWSER_FILES' changed value after including rules.mk. Was '', now browser/head.js browser/crashreport.sjs browser/browser_aboutCrashes.js browser/browser_bug471404.js browser/browser_aboutCrashesResubmit.js ..  Stop.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/137efb901fc9

Comment 5

[Ed Morley [:emorley]]

Backed out for:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1&rev=f4796a2c5af3

https://tbpl.mozilla.org/php/getParsedLog.php?id=13877584&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13877556&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13877580&tree=Mozilla-Inbound
etc

(rest of push left in)

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2dd0b6c4cb4

Comment 6

[Ed Morley [:emorley]]

Sorry s/&onlyunstarred=1// in the previous comment's first URL.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9085598907ef with the fix for that, which was apparently in an earlier patch in my queue.

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/9085598907ef