As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact bugzilla-admin@mozilla.org
Last Comment Bug 777627 - Add MOCHITEST_FILES to FREEZE_VARIABLES
: Add MOCHITEST_FILES to FREEZE_VARIABLES
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 23:01 PDT by Boris Zbarsky [:bz] (still a bit busy)
Modified: 2012-07-27 09:02 PDT (History)
3 users (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make sure we can't accidentally turn off mochitests for a directory by reordering the Makefile.in. (1.53 KB, patch)
2012-07-25 23:03 PDT, Boris Zbarsky [:bz] (still a bit busy)
khuey: review+
Details | Diff | Splinter Review

Description User image Boris Zbarsky [:bz] (still a bit busy) 2012-07-25 23:01:58 PDT
So we don't disable them by accident.
Comment 1 User image Boris Zbarsky [:bz] (still a bit busy) 2012-07-25 23:03:13 PDT
Created attachment 646037 [details] [diff] [review]
Make sure we can't accidentally turn off mochitests for a directory by reordering the Makefile.in.
Comment 2 User image Nathan Froyd [:froydnj] 2012-07-26 04:12:15 PDT
Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?
Comment 3 User image Boris Zbarsky [:bz] (still a bit busy) 2012-07-26 09:31:22 PDT
> Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?

Good catch.  When I do, I get:

/Users/bzbarsky/mozilla/inbound/mozilla/config/rules.mk:1769: *** Makefile variable 'MOCHITEST_BROWSER_FILES' changed value after including rules.mk. Was '', now browser/head.js browser/crashreport.sjs browser/browser_aboutCrashes.js browser/browser_bug471404.js browser/browser_aboutCrashesResubmit.js ..  Stop.
Comment 4 User image Boris Zbarsky [:bz] (still a bit busy) 2012-07-26 09:41:24 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/137efb901fc9
Comment 6 User image Ed Morley [:emorley] 2012-07-26 09:49:55 PDT
Sorry s/&onlyunstarred=1// in the previous comment's first URL.
Comment 7 User image Boris Zbarsky [:bz] (still a bit busy) 2012-07-26 09:57:00 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/9085598907ef with the fix for that, which was apparently in an earlier patch in my queue.

Note You need to log in before you can comment on or make changes to this bug.