So we don't disable them by accident.
Created attachment 646037 [details] [diff] [review] Make sure we can't accidentally turn off mochitests for a directory by reordering the Makefile.in.
Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well?
> Can you go ahead and add the other MOCHITEST_* variables from mochitest.mk as well? Good catch. When I do, I get: /Users/bzbarsky/mozilla/inbound/mozilla/config/rules.mk:1769: *** Makefile variable 'MOCHITEST_BROWSER_FILES' changed value after including rules.mk. Was '', now browser/head.js browser/crashreport.sjs browser/browser_aboutCrashes.js browser/browser_bug471404.js browser/browser_aboutCrashesResubmit.js .. Stop.
Backed out for: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1&rev=f4796a2c5af3 https://tbpl.mozilla.org/php/getParsedLog.php?id=13877584&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=13877556&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=13877580&tree=Mozilla-Inbound etc (rest of push left in) https://hg.mozilla.org/integration/mozilla-inbound/rev/a2dd0b6c4cb4
Sorry s/&onlyunstarred=1// in the previous comment's first URL.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9085598907ef with the fix for that, which was apparently in an earlier patch in my queue.