777649 - 'Remove' context menu is broken for Top Sites awesomescreen entries

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Peter Retzer (:pretzer)]

The 'Remove' context menu action of entries on the awesomescreen Top Sites tab is broken. The toast message that the entry was removed is shown, but the entry stays where it was.
The 'Remove' action on the History tab is working as expected.

Comment 1

[Peter Retzer (:pretzer)]

I reproduced this on the current Nightly. Not sure about Aurora and Beta, but the 'remove' menu item was introduced in 15, so FF14 is unaffected.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Silly me used the wrong ID when I moved this over.

Comment 3

[:Margaret Leibovic]

Comment on attachment 646219 [details] [diff] [review]
Patch

Can you also update the comment in here (and the same copy/pasted comment in BookmarksTab) to reflect the new state of things. You can probably get rid of the comment in BookmarksTab, but it could be worth noting in here why we're using the HISTORY_ID.

Comment 4

[Wesley Johnston (:wesj)]

Comments updated:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fcfa1a0d69

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 646219 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 759041
User impact if declined: Remove option doesn't work
Testing completed (on m-c, etc.): Landing on mc now
Risk to taking this patch (and alternatives if risky): Very low risk. Remove doesn't work without this. Fixes a regression from 14 introduced during a refactor. Returns to the old behavior.
String or UUID changes made by this patch: None.

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/a9fcfa1a0d69

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ebf55549de6b