Last Comment Bug 777668 - B2G RIL: EF_PATH_DF_PHONEBOOK not defined
: B2G RIL: EF_PATH_DF_PHONEBOOK not defined
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla17
Assigned To: Yoshi Huang[:allstars.chh] (OOO ~ 9.30)
:
:
Mentors:
Depends on:
Blocks: 1157082
  Show dependency treegraph
 
Reported: 2012-07-26 03:17 PDT by Yoshi Huang[:allstars.chh] (OOO ~ 9.30)
Modified: 2015-04-21 20:58 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (980 bytes, patch)
2012-07-26 03:20 PDT, Yoshi Huang[:allstars.chh] (OOO ~ 9.30)
vicamo: review+
Details | Diff | Splinter Review

Description Yoshi Huang[:allstars.chh] (OOO ~ 9.30) 2012-07-26 03:17:31 PDT
I found EF_PATH_DF_PHONEBOOK is not defined,
It should be regression from Bug 754018,
The original patch [1] still has that line, (which got r+),
but somehow I accidentally remove that line in my the final patch(v7).

Sorry for my mistake

[1]: https://bugzilla.mozilla.org/attachment.cgi?id=626280&action=diff
Comment 1 Yoshi Huang[:allstars.chh] (OOO ~ 9.30) 2012-07-26 03:20:07 PDT
Created attachment 646077 [details] [diff] [review]
Patch

Hi, Vicamo
Can you review this patch for me ?

Thanks
Comment 2 Vicamo Yang [:vicamo][:vyang] 2012-07-26 03:22:51 PDT
Comment on attachment 646077 [details] [diff] [review]
Patch

Review of attachment 646077 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Comment 3 Yoshi Huang[:allstars.chh] (OOO ~ 9.30) 2012-07-26 03:26:54 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/a6ec0c6749bb
Comment 4 Matt Brubeck (:mbrubeck) 2012-07-26 14:08:49 PDT
https://hg.mozilla.org/mozilla-central/rev/a6ec0c6749bb

Note You need to log in before you can comment on or make changes to this bug.