Closed Bug 777803 Opened 12 years ago Closed 12 years ago

Enable -Wfloat-equal on gcc and clang

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

Details

This may help people catch things like bug 777494.
I don't think we should enable this warning because there are completely legitimate cases where we do equality tests. E.g nsFrame::BuildDisplayListForChild has "disp->mOpacity != 1.0f" which is on a super-hot path and has never needed an epsilon test.
Hmm, yeah ok, I don't have a good solution for such cases.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.