Implement per-window private browsing getter

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: erikvold, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This bug is for simply adding a boolean flag on public window objs that is true if the specific window is in private browsing mode.
Assignee: nobody → evold
Blocks: 748604
Blocks: 777815
Blocks: 777823
Created attachment 646941 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/517

Pointer to Github pull-request
Attachment #646941 - Flags: review?(rFobic)
Comment on attachment 646941 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/517

Almost there but few things need to change before we can land this. Please see details in pull request.

Thanks
Attachment #646941 - Flags: review?(rFobic) → review-
Attachment #646941 - Flags: review- → review+

Comment 3

5 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b1c80d195c33bdb8163ec5836db36f4e6712833d
Merge pull request #517 from erikvold/bug-777813

Bug 777813 Implement per-window private browsing getter r=@gozala
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 4

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/5923e4dda8941165b2def0f89fb1e6cf743fcae4
Merge pull request #517 from erikvold/bug-777813

Bug 777813 Implement per-window private browsing getter r=@gozala(cherry picked from commit b1c80d195c33bdb8163ec5836db36f4e6712833d)
You need to log in before you can comment on or make changes to this bug.