Closed Bug 777877 Opened 8 years ago Closed 7 years ago

Switch CssRuleView.jsm back to WeakMaps

Categories

(DevTools :: Inspector, defect)

13 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: dcamp, Assigned: dcrewi)

References

Details

Attachments

(1 file)

When bug 753517 lands, CssRuleView.jsm can go back to using WeakMaps for edited properties.
This actually needs to depend on another bug, because we have to change what we allow.  That bug in turn depends on bug 753517.  For now, I'll call it bug 777385, though that isn't quite right.
Depends on: 777385
No longer depends on: 753517
Hmm.  I forgot about this. I'll look into how we can add support for these style things this week.
Now that bug 753517 is fixed, the map in UserProperties() should be switched back to a WeakMap.

Search for
Depends on: 753517
Search for 753517 in CssRuleView.jsm.
Is this any more involved than just doing the inverse of the patch from Bug 777373? If there's more to it than that, I volunteer myself to work on it.
(In reply to David Creswick from comment #5)
> Is this any more involved than just doing the inverse of the patch from Bug
> 777373? If there's more to it than that, I volunteer myself to work on it.

I don't think there's more to it. Thanks for offering. Assigned.
Assignee: dcamp → dcrewi
Attached patch patchSplinter Review
Attachment #733400 - Flags: review?(mratcliffe)
Comment on attachment 733400 [details] [diff] [review]
patch

Review of attachment 733400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r+.
Attachment #733400 - Flags: review?(mratcliffe) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ec873217d6e2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.