Closed Bug 777925 Opened 10 years ago Closed 9 years ago

Remove HTML editor logging support

Categories

(Core :: DOM: Editor, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ehsan.akhgari, Assigned: avp)

Details

(Whiteboard: [mentor=ehsan][lang=c++])

Attachments

(1 file, 1 obsolete file)

We should remove nsHTMLEditorLog and all of the ENABLE_EDITOR_API_LOG cruft.  I have never used it and I don't know if anyone else has, and I don't think it's particularly useful at all (or if it works at all!).

Gregory, you'll find this interesting since this will simplify the editor makefiles a bit!
Whiteboard: [mentor=ehsan][lang=c++]
Hi Ehsan,

I am interested in working on this bug. Could you please guide me on getting started on this bug.....




Thanks.
Sure.  Here's a rough guide:

1. Remove editor/idl/nsIEditorLogging.idl (and the corresponding lines in the makefile).
2. Remove editor/libeditor/html/nsHTMLEditorLog.{h,cpp} (and the corresponding lines in the makefile).
3. Rebuild Firefox to see if the build finishes successfully.  I believe that the above two steps are enough though.

Thanks!
I rebuilt firefox after making the changes and build finished successfully.
Attachment #657684 - Flags: feedback?(ehsan)
Comment on attachment 657684 [details] [diff] [review]
Removed HTML Editor Logging Support

Review of attachment 657684 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good!  Thanks for your patch.  Please attach a new version of the patch which addresses the below nit, and then the patch will be ready to land!  :-)

::: editor/libeditor/html/Makefile.in
@@ +41,4 @@
>             $(NULL)
>  
>  ifdef ENABLE_EDITOR_API_LOG
> +CPPSRCS += nsEditorTxnLog.cpp              \         

Can you please remove the trailing whitespace on this line?
Attachment #657684 - Flags: feedback?(ehsan) → review+
Assignee: nobody → abhishekp.bugzilla
Attachment #657684 - Attachment is obsolete: true
Attachment #658114 - Flags: review?(ehsan)
Comment on attachment 658114 [details] [diff] [review]
Removed HTML Editor Logging Support

Review of attachment 658114 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #658114 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/4d0c323f748f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.