777925 - Remove HTML editor logging support

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

We should remove nsHTMLEditorLog and all of the ENABLE_EDITOR_API_LOG cruft.  I have never used it and I don't know if anyone else has, and I don't think it's particularly useful at all (or if it works at all!).

Gregory, you'll find this interesting since this will simplify the editor makefiles a bit!

Comment 1

[Abhishek Potnis [:avp]]

Hi Ehsan,

I am interested in working on this bug. Could you please guide me on getting started on this bug.....




Thanks.

Comment 2

[(no longer active)]

Sure.  Here's a rough guide:

1. Remove editor/idl/nsIEditorLogging.idl (and the corresponding lines in the makefile).
2. Remove editor/libeditor/html/nsHTMLEditorLog.{h,cpp} (and the corresponding lines in the makefile).
3. Rebuild Firefox to see if the build finishes successfully.  I believe that the above two steps are enough though.

Thanks!

Comment 3

[Abhishek Potnis [:avp]]

Attachment: Removed HTML Editor Logging Support

I rebuilt firefox after making the changes and build finished successfully.

Comment 4

[(no longer active)]

Comment on attachment 657684 [details] [diff] [review]
Removed HTML Editor Logging Support

Review of attachment 657684 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good!  Thanks for your patch.  Please attach a new version of the patch which addresses the below nit, and then the patch will be ready to land!  :-)

::: editor/libeditor/html/Makefile.in
@@ +41,4 @@
>             $(NULL)
>  
>  ifdef ENABLE_EDITOR_API_LOG
> +CPPSRCS += nsEditorTxnLog.cpp              \         

Can you please remove the trailing whitespace on this line?

Comment 5

[Abhishek Potnis [:avp]]

Attachment: Removed HTML Editor Logging Support

Comment 6

[(no longer active)]

Comment on attachment 658114 [details] [diff] [review]
Removed HTML Editor Logging Support

Review of attachment 658114 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d0c323f748f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d0c323f748f