Closed Bug 777942 Opened 10 years ago Closed 10 years ago

Add a label to nsDOMStorage::GetItem()

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file, 1 obsolete file)

This call can take a long time because it can require main thread IO
Attachment #646353 - Flags: review?(ehsan)
Attachment #646353 - Flags: review?(ehsan) → review+
I asked this before, but have forgotten the answer: how much does a SAMPLE_LABEL
slow down performance in release builds?
...should we sample only the case when I/O is actually needed?
(In reply to comment #1)
> I asked this before, but have forgotten the answer: how much does a
> SAMPLE_LABEL
> slow down performance in release builds?

It creates a SamplerStackFrameRAII object on the stack: http://mxr.mozilla.org/mozilla-central/source/tools/profiler/sps_sampler.h#154
Comment on attachment 646353 [details] [diff] [review]
Add a label to nsDOMStorage::GetItem()

(As discussed on IRC, please move this sample to the IO case).
This adds labels for the sqlite and cross process implementations.
Attachment #646353 - Attachment is obsolete: true
Attachment #646626 - Flags: review?(ehsan)
Attachment #646626 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/38fd00ed7571
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.