The default bug view has changed. See this FAQ.

Add a label to nsDOMStorage::GetItem()

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 646353 [details] [diff] [review]
Add a label to nsDOMStorage::GetItem()

This call can take a long time because it can require main thread IO
Attachment #646353 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #646353 - Flags: review?(ehsan) → review+
I asked this before, but have forgotten the answer: how much does a SAMPLE_LABEL
slow down performance in release builds?
...should we sample only the case when I/O is actually needed?
(In reply to comment #1)
> I asked this before, but have forgotten the answer: how much does a
> SAMPLE_LABEL
> slow down performance in release builds?

It creates a SamplerStackFrameRAII object on the stack: http://mxr.mozilla.org/mozilla-central/source/tools/profiler/sps_sampler.h#154
Comment on attachment 646353 [details] [diff] [review]
Add a label to nsDOMStorage::GetItem()

(As discussed on IRC, please move this sample to the IO case).
(Assignee)

Comment 5

5 years ago
Created attachment 646626 [details] [diff] [review]
Add labels to the parts of GetItem that are likely to take a long time.

This adds labels for the sqlite and cross process implementations.
Attachment #646353 - Attachment is obsolete: true
Attachment #646626 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #646626 - Flags: review?(ehsan) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/38fd00ed7571
Assignee: nobody → jmuizelaar
https://hg.mozilla.org/mozilla-central/rev/38fd00ed7571
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.