777942 - Add a label to nsDOMStorage::GetItem()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add a label to nsDOMStorage::GetItem()

This call can take a long time because it can require main thread IO

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I asked this before, but have forgotten the answer: how much does a SAMPLE_LABEL
slow down performance in release builds?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

...should we sample only the case when I/O is actually needed?

Comment 3

[(no longer active)]

(In reply to comment #1)
> I asked this before, but have forgotten the answer: how much does a
> SAMPLE_LABEL
> slow down performance in release builds?

It creates a SamplerStackFrameRAII object on the stack: http://mxr.mozilla.org/mozilla-central/source/tools/profiler/sps_sampler.h#154

Comment 4

[(no longer active)]

Comment on attachment 646353 [details] [diff] [review]
Add a label to nsDOMStorage::GetItem()

(As discussed on IRC, please move this sample to the IO case).

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add labels to the parts of GetItem that are likely to take a long time.

This adds labels for the sqlite and cross process implementations.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38fd00ed7571

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38fd00ed7571