Closed Bug 777973 Opened 12 years ago Closed 12 years ago

Don't always invalidateAuthToken in Android Sync onPerformSync

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa+])

At the moment, Android Sync invalidates its Android auth token on every sync.  This is because Android Sync depends on the auth token bundle containing more than just the auth token, and only new auth token bundles contain this additional information.  Invalidating auth tokens every sync with multiple accounts using the same Authenticator/Account type causes timing and race conditions in our SyncAdapter, so we shouldn't do it.

Luckily, it's easy to extract the additional information directly from the Android Account object (rather than go through the auth token bundle dance).

For an alternate, more future proof/comprehensive approach, see Bug 769506.
Blocks: 761206
No longer blocks: 761682
https://hg.mozilla.org/integration/mozilla-inbound/rev/452e01f58420

QA: just check for no instance of "invalidating auth token", and Sync still working for repeated syncs.
Status: NEW → ASSIGNED
Whiteboard: [qa+]
Target Milestone: --- → mozilla17
Rode along with:

https://bugzilla.mozilla.org/show_bug.cgi?id=761682#c7

Merged to m-c in:

https://hg.mozilla.org/mozilla-central/rev/452e01f58420
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.