mozmill should set focusmanager.testmode

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: k0scist, Assigned: moijes12)

Tracking

Details

(Whiteboard: [mentor=jhammel][lang=py])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
see https://bugzilla.mozilla.org/show_bug.cgi?id=758233

this will be removed from the default mozprofile preferences:

https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/profile.py#L249

(in fact many of these should be upstreamed, but lets take them one at
a time)

So Mozmill should set this.  Should be easy enough
(Reporter)

Updated

6 years ago
Blocks: 758233
Whiteboard: [mentor=jhammel][lang=py]
(Assignee)

Comment 1

6 years ago
Created attachment 722672 [details] [diff] [review]
Patch

I haveen't added a check to see whether preferences already contains focusmanager.testmode. I've assumed that when this patch would be applied, the corresponding line from mozrunner would be deleted.
Assignee: nobody → moijes12
Status: NEW → ASSIGNED
Comment on attachment 722672 [details] [diff] [review]
Patch

Thank you for the patch. But please do not forget to ask for review from the assigned mentor.
Attachment #722672 - Flags: review?(jhammel)
(Reporter)

Comment 3

6 years ago
Comment on attachment 722672 [details] [diff] [review]
Patch

lgtm;  as far as i know, double-setting the pref should not cause issues in the case this is landed before the pref is removed from mozrunner
Attachment #722672 - Flags: review?(jhammel) → review+
Landed as:
https://github.com/mozilla/mozmill/commit/4579ddbf6568efbb1714c1e7a6844e03f3a6a0d3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.