jstests: Fix recently introduced progressbar brokenness on windows

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 646420 [details] [diff] [review]
v0

This is a reorganization that I've been meaning to do for awhile.  Eventually I'd like to color the progressbar in realtime to track test failures and this will make that task much easier.
Attachment #646420 - Flags: review?(dmandelin)
Comment on attachment 646420 [details] [diff] [review]
v0

$ jtm
[   0|   0|   0|Traceback (most recent call last):
  File "../tests/jstests.py", line 267, in <module>
    sys.exit(main())
  File "../tests/jstests.py", line 256, in main
    results.push(NullTestOutput(t))
  File "d:\sources\mozilla-inbound\js\src\tests\lib\results.py", line 150, in push
    self.pb.update(self.n, self.counts)
  File "d:\sources\mozilla-inbound\js\src\tests\lib\progressbar.py", line 43, in update
    Terminal.set_color(layout['color'])
  File "d:\sources\mozilla-inbound\js\src\tests\lib\terminal_win.py", line 100,
in set_color
    color_code |= Terminal.COLOR[color]
KeyError: 'gray'

The 0s do appear in different colors, though.
Attachment #646420 - Flags: review?(dmandelin)
(Assignee)

Comment 2

5 years ago
Created attachment 646427 [details] [diff] [review]
v1: fix bustage

Thanks for testing!  The new version fixes the two bustages.
Attachment #646420 - Attachment is obsolete: true
Attachment #646427 - Flags: review?(dmandelin)
Attachment #646427 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd29008c042
https://hg.mozilla.org/mozilla-central/rev/8bd29008c042
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.