Last Comment Bug 777999 - jstests: Fix recently introduced progressbar brokenness on windows
: jstests: Fix recently introduced progressbar brokenness on windows
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Terrence Cole [:terrence]
: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 17:20 PDT by Terrence Cole [:terrence]
Modified: 2012-07-27 08:58 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (8.66 KB, patch)
2012-07-26 17:20 PDT, Terrence Cole [:terrence]
no flags Details | Diff | Splinter Review
v1: fix bustage (8.66 KB, patch)
2012-07-26 17:34 PDT, Terrence Cole [:terrence]
dmandelin: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2012-07-26 17:20:13 PDT
Created attachment 646420 [details] [diff] [review]
v0

This is a reorganization that I've been meaning to do for awhile.  Eventually I'd like to color the progressbar in realtime to track test failures and this will make that task much easier.
Comment 1 David Mandelin [:dmandelin] 2012-07-26 17:25:11 PDT
Comment on attachment 646420 [details] [diff] [review]
v0

$ jtm
[   0|   0|   0|Traceback (most recent call last):
  File "../tests/jstests.py", line 267, in <module>
    sys.exit(main())
  File "../tests/jstests.py", line 256, in main
    results.push(NullTestOutput(t))
  File "d:\sources\mozilla-inbound\js\src\tests\lib\results.py", line 150, in push
    self.pb.update(self.n, self.counts)
  File "d:\sources\mozilla-inbound\js\src\tests\lib\progressbar.py", line 43, in update
    Terminal.set_color(layout['color'])
  File "d:\sources\mozilla-inbound\js\src\tests\lib\terminal_win.py", line 100,
in set_color
    color_code |= Terminal.COLOR[color]
KeyError: 'gray'

The 0s do appear in different colors, though.
Comment 2 Terrence Cole [:terrence] 2012-07-26 17:34:25 PDT
Created attachment 646427 [details] [diff] [review]
v1: fix bustage

Thanks for testing!  The new version fixes the two bustages.
Comment 3 Terrence Cole [:terrence] 2012-07-26 18:10:02 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd29008c042

Note You need to log in before you can comment on or make changes to this bug.