778091 - Low resolution version of flash displayed on all nvidia devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[Catalin Suciu [:csuciu]]

Attachment: screenshot

Fennec 17.0a1 (26-07-2012)
Asus EEE Transformer (Android 4.0.3)

Steps:
Go to http://www.mono-1.com/monoface/main.html or
      http://wechoosethemoon.com
       
Expected:
Site should load at a proper resolution

Actual:
Low resolution version of site is displayed

Note:
The issue is not reproducible on Samsung Galaxy Tab (3.1)

Comment 2

[Aaron Train [:aaronmt]]

Can we get a regression-range, or has this always been the case?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Snorp, thoughts?

Comment 4

[Paul Feher]

The issue is reproducible on 13.0a1 (01/02). It seems to be an older issue. Should we continue to search?

Comment 5

[Paul Feher]

Sorry for the comment above, the Firefox 13.0a1 version wasn't for tablet UI, in consequence, I'm removing the regressionwindow-wanted keyword.

Comment 7

[Aaron Train [:aaronmt]]

Snorp, thoughts?

Comment 10

[Chet McNeill]

I can verify issue still exists on Asus TF300T tablet, Android 4.1.1, Firefox 17.0a2 2012-09-11. Using https://wwws.betterment.com/App.html to reproduce.

Comment 11

[mario.schrijver]

It is still low res on the Asus TF101 using Android 4x.

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use medium precision for OpenGL ES shaders

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 661815 [details] [diff] [review]
Use medium precision for OpenGL ES shaders

Do we need mediump everywhere?  It can/is a perf hit in some cases -- causing the GPU to be able to process 2 fragments instead of 4 at a time (or 2 color components instead of 4)..

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use medium precision for SurfaceTexture shader

Comment 15

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #13)
> Comment on attachment 661815 [details] [diff] [review]
> Use medium precision for OpenGL ES shaders
> 
> Do we need mediump everywhere?  It can/is a perf hit in some cases --
> causing the GPU to be able to process 2 fragments instead of 4 at a time (or
> 2 color components instead of 4)..

Setting the precision only on the relevant shader seems to have the same effect, so I've uploaded a new patch that only changes the single shader.

Comment 16

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 661831 [details] [diff] [review]
Use medium precision for SurfaceTexture shader

># HG changeset patch
># User James Willcox <[e-mail]>
># Date 1347900737 14400
># Node ID 704088ed61a615b972e3cd036920c09e6d06a064
># Parent  3f0587ce17740b77b37d52f687825a6fd76cc916
>Bug 778091 - Use medium precision for SurfaceTexture shader
>
>diff --git a/gfx/layers/opengl/LayerManagerOGLShaders.h b/gfx/layers/opengl/LayerManagerOGLShaders.h
>--- a/gfx/layers/opengl/LayerManagerOGLShaders.h
>+++ b/gfx/layers/opengl/LayerManagerOGLShaders.h
>@@ -241,20 +241,23 @@ precision lowp float;\n\
> \n\
> #ifndef NO_LAYER_OPACITY\n\
> uniform float uLayerOpacity;\n\
> #endif\n\
> #ifdef GL_ES // for tiling, texcoord can be greater than the lowfp range\n\
> varying mediump vec2 vTexCoord;\n\
> #else\n\
> varying vec2 vTexCoord;\n\
> #endif\n\
> \n\
>+#ifdef GL_ES\n\
>+precision mediump float;\n\
>+#endif\n\

The precision qualifier should go first in the file, and then you can get rid of the #ifdef GL_ES mediump bits like you did in the previous patches; but do it just for these shaders.

Comment 17

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use medium precision for SurfaceTexture shader

Comment 18

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 661842 [details] [diff] [review]
Use medium precision for SurfaceTexture shader

Sure, looks good to me.

Comment 19

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd9019f20ca4

Comment 20

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 661842 [details] [diff] [review]
Use medium precision for SurfaceTexture shader

[Approval Request Comment]
Fixes highly visible Flash bug, beta blocker. Low risk.

Comment 21

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/fd9019f20ca4

Comment 22

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 661842 [details] [diff] [review]
Use medium precision for SurfaceTexture shader

Low risk but let's get this in now so it can go out in Beta 4 which builds today to ensure we have time to backout before final builds if there was obvious fallout.

Comment 23

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/13e54dfe4ebc

Comment 24

[Scoobidiver (away)]

Pushed to Aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/f306fa59ad2a

Comment 25

[Aaron Train [:aaronmt]]

QA Note: Nicolae, please verify this on the next Beta build. I'll look at the TF201.

Comment 26

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #25)
> QA Note: Nicolae, please verify this on the next Beta build. I'll look at
> the TF201.

Sure, I will do.

There is a 5 stars video quality on the latest Nightly build. 

--
Firefox 18.0a1 (2012-09-20)
Device: Galaxy Tab 10.1
OS: Android 3.1

Comment 27

[keyholder]

On Acer A200:

Firefox 17 - fixed
Firefox 16 - affected

Please try this to verify: http://www.zdf.de/ZDFmediathek/#/hauptnavigation/startseite

The whole side is flash.

Comment 28

[Aaron Train [:aaronmt]]

(In reply to keyholder from comment #27)
> On Acer A200:
> 
> Firefox 17 - fixed
> Firefox 16 - affected
> 
> Please try this to verify:
> http://www.zdf.de/ZDFmediathek/#/hauptnavigation/startseite
> 
> The whole side is flash.

Yes, this will be fixed in this week's Beta build.

Comment 29

[Cristian Nicolae (:xti)]

Indeed, this issue was fixed on the latest Beta build and Aurora either. Closing bug as verified fixed on:

Firefox 16.0b5 (2012-09-26)
Device: Galaxy Tab 10.1
OS: Android 3.1