The default bug view has changed. See this FAQ.

nsOggReader::GetBuffered treats PageSyncResult as nsresult

RESOLVED FIXED in mozilla17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Unassigned)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

There's a "return PAGE_SYNC_ERROR;" in there, added by bug 584615.  This is wrong -- PAGE_SYNC_ERROR is equal to 1, which isn't a valid nsresult, and will be interpreted as successful.
Thanks for filing this bug. Thankfully is return value doesn't propagate all the way up to JS.

We hit this case when we detect a page from a stream we've not encountered before (like a new link in a chain or a live stream).

I think we can just return NS_OK in this case.
Created attachment 647736 [details] [diff] [review]
Patch
Attachment #647736 - Flags: review?(chris.double)

Comment 3

5 years ago
Comment on attachment 647736 [details] [diff] [review]
Patch

Review of attachment 647736 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/ogg/nsOggReader.cpp
@@ +1621,5 @@
>          continue;
>        }
>        else {
>          // Page is for a stream we don't know about (possibly a chained
>          // ogg), return an error.

Might want to change the comment since we're no longer returning an error.
Attachment #647736 - Flags: review?(chris.double) → review+
With comment changed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fc0a0b7fdda
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/3fc0a0b7fdda
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.