778109 - nsFtpState methods can return FTP_STATE instead of nsresult

Status: RESOLVED WONTFIX

(Core Graveyard :: Networking: FTP, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

nsFtpState::S_list and nsFtpState::S_pasv are supposed to return nsresult, but both have codepaths that return FTP_ERROR.  This is < 0x80000000 and so will register as NS_SUCCEEDED(), which is probably not what was intended.

Comment 1

[Patrick McManus [:mcmanus]]

We are in a period where ftp is clearly deprecated and in general, making changes to the code is riskier than letting it ride unless there is a patch and reviewer available to make a good judgment about it. So I'm going to wontfix ftp bugs related to enhancements, interop errors, etc.. We will be better off putting our energy into including a different js based ftp stack.