778124 - [ia] Implement new locale switcher view

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

The designs for the new IA have a page for switching locale that is linked to from the new header. This replaces the current dropdown selector in the footer.

Some details:
* The view should probably live in apps/sumo, unless you can think of a more logical home for it.
* The url should be /<current locale>/locales
* After selecting a language, the user should be redirected back to the same page they were on before but in the new locale. This is tricky for KB pages because the slug can be different for each locale. See current implementation.

This bug is about getting the working view in and linked to from the header (bug 777509). We'll deal with nailing the style in a later bug (we don't have designs for this page yet).

Comment 1

[Kadir Topal [:atopal]]

Bram, can you clarify what we want to do here? I thought we'd re-purpose the current language switcher and would move it to the top. Do we really need an extra page to show languages? If yes, we'd need a mock-up I assume, it wasn't part of Lee's deliverables.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #1)
> Bram, can you clarify what we want to do here? I thought we'd re-purpose the
> current language switcher and would move it to the top. Do we really need an
> extra page to show languages?

I think it would be great to move it to a new page. Right now a good % chunk of the HTML on every single page loaded is that dropdown with ~80 or so languages in it.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

We need to list all the enabled locales in a template and pass around the page the user comes from in the query string to redirect forward. We need good tests for this. I don't think it shouldn't take more than a day => 2pt

Comment 4

[Bram Pitoyo [:bram]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #2)
> (In reply to Kadir Topal [:atopal] from comment #1)
> > Bram, can you clarify what we want to do here? I thought we'd re-purpose the
> > current language switcher and would move it to the top. Do we really need an
> > extra page to show languages?
> 
> I think it would be great to move it to a new page. Right now a good % chunk
> of the HTML on every single page loaded is that dropdown with ~80 or so
> languages in it.

That’s correct. Our plan for this was to show the language in a new page. I am going to mock it up today.

Comment 5

[Bram Pitoyo [:bram]]

See attachment 647830 [details] and attachment 647837 [details] for two possible language picker designs.

In this implementation, I sorted the language based on completion of coverage, according to the SUMO Locales information document:

https://docs.google.com/spreadsheet/ccc?key=0ApOS1XP_5PqvdGN6M0tLdzQxVFBRaDhmSDV5dnF5NFE#gid=0

Comment 6

[Kadir Topal [:atopal]]

That list is changing constantly. How about using the wikipedia method and listing them by their locale code? eg: de, fr, it, ja

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #6)
> That list is changing constantly. How about using the wikipedia method and
> listing them by their locale code? eg: de, fr, it, ja

Are you suggesting we sort them alphabetically by locale code? It would be much easier to implement that way (no dependence on analytics data). Also, as a user I think it makes sense because I'd quickly will notice the sort is alphabetical rather than what can seem random.

Comment 8

[Bram Pitoyo [:bram]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #7)
> (In reply to Kadir Topal [:atopal] from comment #6)
> > That list is changing constantly. How about using the wikipedia method and
> > listing them by their locale code? eg: de, fr, it, ja
> 
> Are you suggesting we sort them alphabetically by locale code? It would be
> much easier to implement that way (no dependence on analytics data). Also,
> as a user I think it makes sense because I'd quickly will notice the sort is
> alphabetical rather than what can seem random.

Any sorting method is fine with me. Alphabetical is good.

Comment 9

[Kadir Topal [:atopal]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #7)
> (In reply to Kadir Topal [:atopal] from comment #6)
> > That list is changing constantly. How about using the wikipedia method and
> > listing them by their locale code? eg: de, fr, it, ja
> 
> Are you suggesting we sort them alphabetically by locale code? It would be
> much easier to implement that way (no dependence on analytics data). Also,
> as a user I think it makes sense because I'd quickly will notice the sort is
> alphabetical rather than what can seem random.

Yes, let's go with that.

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request: https://github.com/mozilla/kitsune/pull/769

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/d58c1c9c87c58fd230b7c54ba8e9946b0922ab43

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

Just landed in prod.