778230 - remove wildcard calls from robocop's Makefile.in

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 646656 [details] [diff] [review]
patch

Review of attachment 646656 [details] [diff] [review]:
-----------------------------------------------------------------

One thing that concerns me is that the file list is not in the same directory as the files, which is likely to cause confusion when people add new tests (or remove old ones). Mark, what do you think?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 646656 [details] [diff] [review]
patch

I agree that being in different folders is not the best situation, but we should look at that issue in a different bug. This patch does bring the file in-line with other test makefiles, where we explicitly list the files.

Comment 4

[Nathan Froyd [:froydnj]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c0a09f9d5215

Comment 5

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out because of build errors:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67c6d1cabab1

https://tbpl.mozilla.org/php/getParsedLog.php?id=14042245&tree=Mozilla-Inbound
make[6]: *** No rule to make target `/builds/slave/m-in-andrd-xul/build/mobile/android/base/tests//builds/slave/m-in-andrd-xul/build/mobile/android/base/tests/BaseTest.java.in', needed by `/builds/slave/m-in-andrd-xul/build/mobile/android/base/tests/BaseTest.java'. Stop.

Comment 6

[Matt Brubeck (:mbrubeck)]

It looks like $(TESTPATH) is prepended to the .java.in filenames here:
http://hg.mozilla.org/integration/mozilla-inbound/file/c0a09f9d5215/build/mobile/robocop/Makefile.in#l131

so it should not be prepended to the .java filenames here:
http://hg.mozilla.org/integration/mozilla-inbound/file/c0a09f9d5215/build/mobile/robocop/Makefile.in#l70

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Mitchell Hentges [:mhentges] 🦀]

robocop is no longer in-tree, this is no longer valid.