Last Comment Bug 778231 - Add a button to auto-post csets to bugs
: Add a button to auto-post csets to bugs
Status: RESOLVED INCOMPLETE
:
Product: Tree Management Graveyard
Classification: Graveyard
Component: TBPL (show other bugs)
: Trunk
: All All
: -- normal
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on: 791282
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-27 11:46 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2015-04-13 15:57 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Add m-cMerge links (2.65 KB, patch)
2012-09-11 07:45 PDT, Graeme McCutcheon [:graememcc]
emorley: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-27 11:46:47 PDT
I find it rather tiresome to manually post these.  (I wrote "List changeset URLs" to solve a similar problem.)

But now that tbpl can talk to bugzilla, we should just make a button that posts the cset URL to the affected bugs and do away with "List changeset URLs".
Comment 1 Ed Morley [:emorley] 2012-07-28 02:05:15 PDT
(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> But now that tbpl can talk to bugzilla

TBPL can't actually talk to bugzilla (at least not yet), we are using http://www.graememcc.co.uk/m-cmerge/ (repo: https://bitbucket.org/graememcc/m-cmerge/) to mark merges. (In the future I imagine we'll import the m-cMerge functionality into the TBPL repo, rather than hosting separately).

There is an existing issue open in the bitbucket tracker (https://bitbucket.org/graememcc/m-cmerge/issue/8/glandium-mark-m-i-pushes) for making m-cMerge support marking inbound pushes too.

Once that's fixed, we could just replace the "List changeset URLs" link with one pointing to something like http://www.graememcc.co.uk/m-cmerge/?cset=foo&branch=bar
Comment 2 Matt Brubeck (:mbrubeck) 2012-08-01 15:29:21 PDT
This features is now implemented in m-cmerge.  Example:
http://www.graememcc.co.uk/m-cmerge/?cset=4888b8395089&tree=mozilla-inbound
Comment 3 Graeme McCutcheon [:graememcc] 2012-08-02 07:08:58 PDT
m-cMerge is fairly heavyweight: for single changeset pushes, it'll still be faster to flip over to a Bugzilla tab and cut-and-paste. I think we'll want a different solution for that case.

That said it should be useful for pushes with multiple changesets. I'm happy to put together a patch to add the relevant links to TBPL if you think it'll be a useful first step.
Comment 4 Graeme McCutcheon [:graememcc] 2012-09-11 07:45:46 PDT
Created attachment 660072 [details] [diff] [review]
Add m-cMerge links

Haven't requested review, as I'm still not sure how useful it would be given comment 3, but this adds m-cMerge links to non-Try trees.
Comment 5 Ed Morley [:emorley] 2012-09-14 02:01:01 PDT
Comment on attachment 660072 [details] [diff] [review]
Add m-cMerge links

lgtm :-)

Whilst we could maybe do things like only showing on mozilla-central, or for pushes over size N; I think it's not worth making the UI inconsistent - so as is wfm. (With revised commit message :-))
Comment 6 Graeme McCutcheon [:graememcc] 2012-09-14 05:54:50 PDT
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/e32299202235

Leaving this open for now. We can do better for small pushes.
Comment 7 Ed Morley [:emorley] 2012-09-17 00:59:01 PDT
(In reply to Graeme McCutcheon [:graememcc] from comment #6)
> http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/
> e32299202235

This part is now in production.
Comment 8 Ed Morley [:emorley] 2012-09-17 01:03:33 PDT
I'd like to close this bug now to make things easier to track. cjones, did you still want something to cover the smaller pushes use-case? If so, I'll file another for that and morph the summary of this bug to be just about m-cMerge.
Comment 9 Graeme McCutcheon [:graememcc] 2012-09-17 07:46:30 PDT
I've pulled together some thoughts on small pushes, thoughts/comments welcome:
https://etherpad.mozilla.org/oTyMkUxGzE
Comment 10 Ed Morley [:emorley] 2015-04-08 04:49:05 PDT
TBPL has been EOLed (bug 1054977).

Note You need to log in before you can comment on or make changes to this bug.