lcglue.cpp and nsJVMManager.cpp don't need to include pprthred.h.

VERIFIED FIXED in M14

Status

Core Graveyard
Java: OJI
P5
normal
VERIFIED FIXED
19 years ago
8 years ago

People

(Reporter: Wan-Teh Chang, Assigned: drapeau)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
This is reported by Andreas Otte <andreas.otte@primus-online.de>
in the mozilla.builds newsgroup.

Two files in mozilla/modules/oji/src, lcglue.cpp and
nsJVMManager.cpp, include the semi-private NSPR header
pprthred.h.  While it is fine to include this header
in special circumstances, it should be avoided if
possible.

Looking at these two files, I believe that they don't
need pprthred.h at all.  So I suggest that we remove
#include "pprthred.h" from lcglue.cpp and nsJVMManager.cpp,
remove
    INCLUDES +=             -I$(NSPR_INCLUDE_DIR)/private
from mozilla/modules/oji/src/Makefile.in, and remove
    -I$(DIST)/include/private \
from mozilla/modules/oji/src/makefile.win.

Comment 1

19 years ago
Reassigning all OJI bugs to george.drapeau@eng.sun.com
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → WONTFIX

Comment 2

19 years ago
I tried this modification and on rebuild, got the following error:
D:\Projects\mozilla\modules\oji\src\nsJVMManager.cpp(363) : error C2065:
'PR_smprintf' : undeclared identifier
D:\Projects\mozilla\modules\oji\src\nsJVMManager.cpp(363) : error C2440: '=' :
cannot convert from 'int' to 'char *'
(Reporter)

Comment 3

19 years ago
PR_smprintf is declared in prprf.h.
Please add #include "prprf.h" to
nsJVMManager.cpp and try again.

I just found that pprthred.h includes
nspr.h, which is the mother of all
public NSPR headers.  This is how
nsJVMManager.cpp got the declaration
of PR_smprintf. (pprthred.h includes
nspr.h, which includes prprf.h.)
(Reporter)

Updated

19 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 4

19 years ago
Reopened the bug.

Updated

19 years ago
Resolution: WONTFIX → ---

Comment 5

19 years ago
Clearing Won't Fix resolution due to ReOpen of this bug.
(Assignee)

Updated

19 years ago
Priority: P3 → P5
Target Milestone: M10 → M12
(Assignee)

Updated

19 years ago
Status: REOPENED → ASSIGNED
Target Milestone: M12 → M13
(Assignee)

Comment 6

19 years ago
Fix identified that will clear up the mistaken include; warnings remain when
compiling under Windows, but they don't cause the build to break, and they were
there forever anyway.

Will post a patch and check-in the fix when the tree opens again.

Updated

19 years ago
Target Milestone: M13 → M14

Comment 7

19 years ago
move to m14. let me know if fixes are available. thx.
(Assignee)

Comment 8

19 years ago
Created attachment 5208 [details] [diff] [review]
Fix for 7783 (removal of unnecessary #include defs)
(Assignee)

Comment 9

19 years ago
Finally checked in this age-old fix (removing unnecessary #include statements,
including the semi-private "pprthred.h" header file).
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED

Comment 10

19 years ago
Verified per programmer's ( drapeau@eng.sun.com )comments
Status: RESOLVED → VERIFIED

Updated

8 years ago
Component: Java: OJI → Java: OJI
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.