778328 - deploystudio images should regenerate SSH key

Status: RESOLVED WONTFIX

(Infrastructure & Operations :: RelOps: General, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I've re-deploystudio'd a few minis now, and SSH isn't complaining that the SSH host key has changed.

We should probably have a post-deploy task that regenerates these, otherwise everything will have the same host key.

Comment 1

[Zandr Milewski [:zandr]]

> We should probably have a post-deploy task that regenerates these, otherwise
> everything will have the same host key.

What's the risk there?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

It's minor, but it means that a well-known SSH key will be accepted for a wide range of IPs, and since we generally do password auth, that runs the risk of entering the password for a non-recognized slave.

Comment 3

[Amy Rich [:arr] [:arich]]

Honestly, I think the fact that they have the same key is a feature.  This means that we don't have to remove the key from known_hosts and re-add it every time a machine is reimaged.  I seriously doubt that anyone is going to catch a spoofed machine this way since people log in so infrequently after reimaging that they will automatically accept the new key.  

This might also break any automated jobs that no longer trust the key of a reimaged machine.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Hm, OK..