778371 - Implement |hg pushed| for posting commit comments to bugzilla

Status: RESOLVED WORKSFORME

(Developer Services :: Mercurial: mozext, defect)

Description

[Steve Fink [:sfink] [:s:]]

Ok, so you may find this a little silly. But I hate the process for posting commit ref links in bugs. And bzexport already has my credentials. I will not be offended if you spit on this.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Implement |hg pushed| for posting commit comments to bugzilla

This only posts to a single bug, which is unfortunate, but it's still handy. If this is accepted, I'll beef it up later. If it's rejected, I'll figure out some way to make it work as a separate extension or something.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Expand |hg pushed| to handle multiple bugs

A bit nicer when you push more than one bug at a time.

This also rewrites the url-generating code. I suppose I really ought to merge these patches, though I have several in my queue in between them so I'm not sure how easy it'll be.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Implement |hg pushed| for posting commit comments to bugzilla and optionally marking them fixed

Sorry for the mess. This rolls up all of the |hg pushed| stuff into a single patch.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 656086 [details] [diff] [review]
Implement |hg pushed| for posting commit comments to bugzilla and optionally marking them fixed

Sorry, I should've cancelled this review request a while back. The posted version is buggy, and I'm still tweaking it anyway. It's still a little footgunny.

Comment 5

[Josh Matthews [:jdm]]

I'm going to retcon myself and claim that that's why I did not get around to reviewing it.

Comment 6

[Gregory Szorc [:gps]]

I think this belongs in my mozext extension. My mozext extension already has knowledge of all the official repos and their URLs. I actually have a semi-working patch that does this. Just need to brush it off.

Comment 7

[Gregory Szorc [:gps]]

A lot of the functionality from this patch is implemented in the bzpost extension. I'm calling this WORKSFORME.