All users were logged out of Bugzilla on October 13th, 2018

Implement |hg pushed| for posting commit comments to bugzilla

RESOLVED WORKSFORME

Status

RESOLVED WORKSFORME
6 years ago
4 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/825] )

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Ok, so you may find this a little silly. But I hate the process for posting commit ref links in bugs. And bzexport already has my credentials. I will not be offended if you spit on this.
(Assignee)

Comment 1

6 years ago
Created attachment 646782 [details] [diff] [review]
Implement |hg pushed| for posting commit comments to bugzilla

This only posts to a single bug, which is unfortunate, but it's still handy. If this is accepted, I'll beef it up later. If it's rejected, I'll figure out some way to make it work as a separate extension or something.
Attachment #646782 - Flags: review?(josh)
(Assignee)

Comment 2

6 years ago
Created attachment 656076 [details] [diff] [review]
Expand |hg pushed| to handle multiple bugs

A bit nicer when you push more than one bug at a time.

This also rewrites the url-generating code. I suppose I really ought to merge these patches, though I have several in my queue in between them so I'm not sure how easy it'll be.
Attachment #656076 - Flags: review?(josh)
(Assignee)

Comment 3

6 years ago
Created attachment 656086 [details] [diff] [review]
Implement |hg pushed| for posting commit comments to bugzilla and optionally marking them fixed

Sorry for the mess. This rolls up all of the |hg pushed| stuff into a single patch.
Attachment #656086 - Flags: review?(josh)
(Assignee)

Updated

6 years ago
Attachment #646782 - Attachment is obsolete: true
Attachment #646782 - Flags: review?(josh)
(Assignee)

Updated

6 years ago
Attachment #656076 - Attachment is obsolete: true
Attachment #656076 - Flags: review?(josh)
(Assignee)

Comment 4

6 years ago
Comment on attachment 656086 [details] [diff] [review]
Implement |hg pushed| for posting commit comments to bugzilla and optionally marking them fixed

Sorry, I should've cancelled this review request a while back. The posted version is buggy, and I'm still tweaking it anyway. It's still a little footgunny.
Attachment #656086 - Flags: review?(josh)

Comment 5

6 years ago
I'm going to retcon myself and claim that that's why I did not get around to reviewing it.

Comment 6

5 years ago
I think this belongs in my mozext extension. My mozext extension already has knowledge of all the official repos and their URLs. I actually have a semi-working patch that does this. Just need to brush it off.
Component: bzexport → mozext
Product: Other Applications → Developer Services

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/127]

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/127] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/825] [kanban:engops:https://kanbanize.com/ctrl_board/6/127]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/825] [kanban:engops:https://kanbanize.com/ctrl_board/6/127] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/825]

Comment 7

4 years ago
A lot of the functionality from this patch is implemented in the bzpost extension. I'm calling this WORKSFORME.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.